Skip to content

Annotations not passed as part of CreateSandbox Request #12565

@rawahars

Description

@rawahars

Description

In the implementation of Sandbox Controller, the request includes the following parameters-

message CreateSandboxRequest {
	string sandbox_id = 1;
	string bundle_path = 2;
	repeated containerd.types.Mount rootfs = 3;
	google.protobuf.Any options = 4;
	string netns_path = 5;
	map<string, string> annotations = 6;
}

However, when the request is crafted, we ignore the annotations parameter.

If we set the annotations param as coptions.Annotations, then the user passed annotations will be forwarded to the shim which can act upon the same.

Steps to reproduce the issue

Call SandboxController.Create while passing the param WithAnnotations().

Describe the results you received and expected

The annotations set by user are received in the shim.

What version of containerd are you using?

latest

Any other relevant information

No response

Show configuration if it is related to CRI plugin.

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    Status

    Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions