-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Comparing changes
Open a pull request
base repository: containerd/containerd
base: 4f03e10
head repository: containerd/containerd
compare: 4e1fe74
- 11 commits
- 14 files changed
- 8 contributors
Commits on Nov 16, 2023
-
Enhance container image unpack client logs
Adds debug message per layer unpacking and adds duration field to the existing image unpacking debug message. Signed-off-by: Austin Vazquez <[email protected]> (cherry picked from commit 01c4421) Signed-off-by: Austin Vazquez <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5930a37 - Browse repository at this point
Copy the full SHA 5930a37View commit details -
cri: fix using the pinned label to pin image
Signed-off-by: Iceber Gu <[email protected]> (cherry picked from commit 7f7ba31) Signed-off-by: Iceber Gu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8dc8618 - Browse repository at this point
Copy the full SHA 8dc8618View commit details -
cri: fix update of pinned label for images
Signed-off-by: Iceber Gu <[email protected]> (cherry picked from commit 2e014fa) Signed-off-by: Iceber Gu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a2b16d7 - Browse repository at this point
Copy the full SHA a2b16d7View commit details -
Merge pull request #9379 from austinvazquez/cherry-pick-v1.7-01c44214…
…7fd084cc0e7e8b45074b940f5c6bbdba [release/1.7] Enhance container image unpack client logs
Configuration menu - View commit details
-
Copy full SHA for bb0e42a - Browse repository at this point
Copy the full SHA bb0e42aView commit details
Commits on Nov 17, 2023
-
Merge pull request #9381 from Iceber/fix_pin_image_1.7
[release/1.7] cri: fix using the pinned label to pin image
Configuration menu - View commit details
-
Copy full SHA for b1c6f01 - Browse repository at this point
Copy the full SHA b1c6f01View commit details
Commits on Nov 21, 2023
-
fix: deflake TestCRIImagePullTimeout/HoldingContentOpenWriter
The new active request is filed and there is no bytes read yet when the progress reporter just wakes up. If the timeout / 2 is less than the minPullProgressReportInternal, it's easy to file false alert. We should remove the minPullProgressReportInternal limit. Fixes: #8024 Signed-off-by: Wei Fu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d1aab27 - Browse repository at this point
Copy the full SHA d1aab27View commit details -
Signed-off-by: Wei Fu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3284939 - Browse repository at this point
Copy the full SHA 3284939View commit details -
remotes/docker: close connection if no more data
Close connection if no more data. It's to fix false alert filed by image pull progress. ``` dst = OpenWriter (--> Content Store) src = Fetch Open (--> Registry) Mark it as active request Copy(dst, src) (--> Keep updating total received bytes) ^ | (Active Request > 0, but total received bytes won't be updated) v defer src.Close() content.Commit(dst) ``` Before migrating to transfer service, CRI plugin doesn't limit global concurrent downloads for ImagePulls. Each ImagePull requests have 3 concurrent goroutines to download blob and 1 goroutine to unpack blob. Like ext4 filesystem [1][1], the fsync from content.Commit may sync unrelated dirty pages into disk. The host is running under IO pressure, and then the content.Commit will take long time and block other goroutines. If httpreadseeker doesn't close the connection after io.EOF, this connection will be considered as active. The pull progress reporter reports there is no bytes transfered and cancels the ImagePull. The original 1-minute timeout[2][2] is from kubelet settting. Since CRI-plugin can't limit the total concurrent downloads, this patch is to update 1-minute to 5-minutes to prevent from unexpected cancel. [1]: https://lwn.net/Articles/842385/ [2]: https://github.com/kubernetes/kubernetes/blob/release-1.23/pkg/kubelet/config/flags.go#L45-L48 Signed-off-by: Wei Fu <[email protected]>Configuration menu - View commit details
-
Copy full SHA for 2068061 - Browse repository at this point
Copy the full SHA 2068061View commit details
Commits on Nov 22, 2023
-
Merge pull request #9409 from ruiwen-zhao/progress-fix-1.7
[release/1.7] fix: ImagePull should close http connection if there is no available data to read.
Configuration menu - View commit details
-
Copy full SHA for 21b85e9 - Browse repository at this point
Copy the full SHA 21b85e9View commit details
Commits on Nov 28, 2023
-
Signed-off-by: ruiwen-zhao <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a995fe3 - Browse repository at this point
Copy the full SHA a995fe3View commit details
Commits on Nov 29, 2023
-
Merge pull request #9426 from ruiwen-zhao/1.7.10
Add release notes for v1.7.10
Configuration menu - View commit details
-
Copy full SHA for 4e1fe74 - Browse repository at this point
Copy the full SHA 4e1fe74View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 4f03e10...4e1fe74