Skip to content

Commit f60d447

Browse files
committed
Makefile: fix tags parameter computation
In the current implementation, the build tags arguments can catch up an extra trailing whitespace. Since this parameter is passed in quotes, the shell won't strip it, leading to the wrong tags passed. Therefore just strip it explicitly. Signed-off-by: Enrico Weigelt, metux IT consult <[email protected]>
1 parent 0a3a77b commit f60d447

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ ifdef BUILDTAGS
8989
endif
9090
GO_BUILDTAGS ?=
9191
GO_BUILDTAGS += ${DEBUG_TAGS}
92-
GO_TAGS=$(if $(GO_BUILDTAGS),-tags "$(GO_BUILDTAGS)",)
92+
GO_TAGS=$(if $(GO_BUILDTAGS),-tags "$(strip $(GO_BUILDTAGS))",)
9393
GO_LDFLAGS=-ldflags '-X $(PKG)/version.Version=$(VERSION) -X $(PKG)/version.Revision=$(REVISION) -X $(PKG)/version.Package=$(PACKAGE) $(EXTRA_LDFLAGS)'
9494
SHIM_GO_LDFLAGS=-ldflags '-X $(PKG)/version.Version=$(VERSION) -X $(PKG)/version.Revision=$(REVISION) -X $(PKG)/version.Package=$(PACKAGE) -extldflags "-static" $(EXTRA_LDFLAGS)'
9595

0 commit comments

Comments
 (0)