pkg/cri/streaming: increase ReadHeaderTimeout

fuweid · thaJeztah · commit efb88a8bbcdb · 2023-03-08T00:11:34.000+01:00
It is follow-up of #7254. This commit will increase ReadHeaderTimeout from 3s to 30m, which prevent from unexpected timeout when the node is running with high-load. 30 Minutes is longer enough to get close to before what #7254 changes. And ideally, we should allow user to configure the streaming server if the users want this feature. Signed-off-by: Wei Fu <fuweid89@gmail.com> (cherry picked from commit 460b053) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
diff --git a/pkg/cri/streaming/server.go b/pkg/cri/streaming/server.go
@@ -162,10 +162,11 @@ func NewServer(config Config, runtime Runtime) (Server, error) {
 	handler.Add(ws)
 	s.handler = handler
 	s.server = &http.Server{
-		Addr:              s.config.Addr,
-		Handler:           s.handler,
-		TLSConfig:         s.config.TLSConfig,
-		ReadHeaderTimeout: 3 * time.Second, // Fix linter G112: Potential Slowloris Attack because ReadHeaderTimeout is not configured in the http.Server
+		Addr:      s.config.Addr,
+		Handler:   s.handler,
+		TLSConfig: s.config.TLSConfig,
+		// TODO(fuweid): allow user to configure streaming server
+		ReadHeaderTimeout: 30 * time.Minute, // Fix linter G112: Potential Slowloris Attack because ReadHeaderTimeout is not configured in the http.Server
 	}
 
 	return s, nil
