Merge pull request #5000 from kzys/fix-assert-check

crosbymichael · web-flow · commit e9e3b1d6fde0 · 2021-02-04T16:11:24.000-05:00
test: fix assert.Check's argumets to show its parameters correctly
diff --git a/snapshots/devmapper/snapshotter_test.go b/snapshots/devmapper/snapshotter_test.go
@@ -137,7 +137,7 @@ func testUsage(t *testing.T, snapshotter snapshots.Snapshotter) {
 
 	// Should be at least 1 MB + fs metadata
 	assert.Check(t, layer2Usage.Size > sizeBytes,
-		"%d > %d", layer2Usage.Size > sizeBytes)
+		"%d > %d", layer2Usage.Size, sizeBytes)
 	assert.Check(t, layer2Usage.Size < sizeBytes+256*dmsetup.SectorSize,
-		"%d < %d", layer2Usage.Size < sizeBytes+256*dmsetup.SectorSize)
+		"%d < %d", layer2Usage.Size, sizeBytes+256*dmsetup.SectorSize)
 }

Original file line number	Diff line number	Diff line change
`@@ -137,7 +137,7 @@ func testUsage(t *testing.T, snapshotter snapshots.Snapshotter) {`
`137`	`137`
`138`	`138`	`// Should be at least 1 MB + fs metadata`
`139`	`139`	`assert.Check(t, layer2Usage.Size > sizeBytes,`
`140`		`- "%d > %d", layer2Usage.Size > sizeBytes)`
	`140`	`+ "%d > %d", layer2Usage.Size, sizeBytes)`
`141`	`141`	`assert.Check(t, layer2Usage.Size < sizeBytes+256*dmsetup.SectorSize,`
`142`		`- "%d < %d", layer2Usage.Size < sizeBytes+256*dmsetup.SectorSize)`
	`142`	`+ "%d < %d", layer2Usage.Size, sizeBytes+256*dmsetup.SectorSize)`
`143`	`143`	`}`