Skip to content

Commit da8e846

Browse files
fuweidk8s-infra-cherrypick-robot
authored andcommitted
.github: skip 5 critest cases in window CI pipeline
Signed-off-by: Wei Fu <[email protected]>
1 parent b0731e8 commit da8e846

1 file changed

Lines changed: 16 additions & 4 deletions

File tree

.github/workflows/ci.yml

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -348,13 +348,25 @@ jobs:
348348
Start-Process -FilePath containerd.exe -NoNewWindow -RedirectStandardError true -PassThru
349349
get-process | sls containerd
350350
start-sleep 5
351-
# This test is exceedingly flaky only on ws2022 so skip for now to keep CI happy.
352-
# Info: https://github.com/containerd/containerd/issues/6652
353351
if( '${{ matrix.os }}' -eq 'windows-2022' )
354352
{
355-
$skip = "-ginkgo.skip=runtime should support exec with tty=true and stdin=true"
353+
$skipTests = @(
354+
# This test is exceedingly flaky only on ws2022 so skip for now to keep CI happy.
355+
# Info: https://github.com/containerd/containerd/issues/6652
356+
"runtime should support exec with tty=true and stdin=true",
357+
358+
# Skip tests that are known to be flaky on Windows
359+
# See https://github.com/containerd/containerd/issues/12580
360+
"public image with tag should be pulled and removed",
361+
"public image without tag should be pulled and removed",
362+
"image status should support all kinds of references",
363+
"listImage should get exactly 3 image in the result list",
364+
"listImage should get exactly 3 repoTags in the result image"
365+
)
366+
$skip = $skipTests -join "|"
356367
}
357-
critest.exe --runtime-endpoint=npipe://.//pipe//containerd-containerd --test-images-file='${{env.CRI_TEST_IMAGES}}' --report-dir='${{github.workspace}}/critestreport' $skip
368+
Write-Host "Skip parameters: $skip"
369+
critest.exe --runtime-endpoint=npipe://.//pipe//containerd-containerd --test-images-file='${{env.CRI_TEST_IMAGES}}' --report-dir='${{github.workspace}}/critestreport' --ginkgo.skip="$skip"
358370
359371
- uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4 # v5.0.0
360372
if: always()

0 commit comments

Comments
 (0)