Merge pull request #3263 from Random-Liu/fix-task-deletion

estesp · web-flow · commit d68b593de4ab · 2019-05-07T23:12:14.000+02:00
Fix error handling for task deletion.
diff --git a/runtime/v2/shim.go b/runtime/v2/shim.go
@@ -156,7 +156,7 @@ func (s *shim) Delete(ctx context.Context) (*runtime.Exit, error) {
 	response, err := s.task.Delete(ctx, &task.DeleteRequest{
 		ID: s.ID(),
 	})
-	if err != nil && errdefs.IsNotFound(err) {
+	if err != nil && !errdefs.IsNotFound(err) {
 		return nil, errdefs.FromGRPC(err)
 	}
 	if err := s.waitShutdown(ctx); err != nil {

Original file line number	Diff line number	Diff line change
`@@ -156,7 +156,7 @@ func (s shim) Delete(ctx context.Context) (runtime.Exit, error) {`
`156`	`156`	`response, err := s.task.Delete(ctx, &task.DeleteRequest{`
`157`	`157`	`ID: s.ID(),`
`158`	`158`	`})`
`159`		`- if err != nil && errdefs.IsNotFound(err) {`
	`159`	`+ if err != nil && !errdefs.IsNotFound(err) {`
`160`	`160`	`return nil, errdefs.FromGRPC(err)`
`161`	`161`	`}`
`162`	`162`	`if err := s.waitShutdown(ctx); err != nil {`