Skip to content

Commit bd51841

Browse files
committed
🚨 HACK: Disable parallel snapshot testsuite on Windows
Running the test suite in parallel (the default for the unit tests and the first integration suite pass) sees "file in use" issues, but those don't appear to affect non-parallel runs. This hack is to confirm that hypothesis, as we should get a consistent test run, as we roll forward with rebases etc. Signed-off-by: Paul "TBBle" Hampson <[email protected]>
1 parent 1b13b58 commit bd51841

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

‎snapshots/testsuite/testsuite.go‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,10 @@ func SnapshotterSuite(t *testing.T, name string, snapshotterFn SnapshotterFunc)
7676

7777
func makeTest(name string, snapshotterFn func(ctx context.Context, root string) (snapshots.Snapshotter, func() error, error), fn func(ctx context.Context, t *testing.T, snapshotter snapshots.Snapshotter, work string)) func(t *testing.T) {
7878
return func(t *testing.T) {
79-
t.Parallel()
79+
if runtime.GOOS != "windows" {
80+
// HACK! Parallel snapshot testsuite is having issues. @tbble thinks this is a HCS-level problem.
81+
t.Parallel()
82+
}
8083

8184
ctx := logtest.WithT(context.Background(), t)
8285
ctx = namespaces.WithNamespace(ctx, "testsuite")

0 commit comments

Comments
 (0)