Merge pull request #5440 from Iceber/optimize-last-registration

fuweid · web-flow · commit b9e1d0cd279f · 2021-05-13T10:51:36.000+08:00
plugin: optimize the check for the last registration
diff --git a/plugin/plugin.go b/plugin/plugin.go
@@ -171,15 +171,11 @@ func Register(r *Registration) {
 		panic(err)
 	}
 
-	var last bool
 	for _, requires := range r.Requires {
-		if requires == "*" {
-			last = true
+		if requires == "*" && len(r.Requires) != 1 {
+			panic(ErrInvalidRequires)
 		}
 	}
-	if last && len(r.Requires) != 1 {
-		panic(ErrInvalidRequires)
-	}
 
 	register.r = append(register.r, r)
 }

Original file line number	Diff line number	Diff line change
`@@ -171,15 +171,11 @@ func Register(r *Registration) {`
`171`	`171`	`panic(err)`
`172`	`172`	`}`
`173`	`173`
`174`		`- var last bool`
`175`	`174`	`for _, requires := range r.Requires {`
`176`		`- if requires == "*" {`
`177`		`- last = true`
	`175`	`+ if requires == "*" && len(r.Requires) != 1 {`
	`176`	`+ panic(ErrInvalidRequires)`
`178`	`177`	`}`
`179`	`178`	`}`
`180`		`- if last && len(r.Requires) != 1 {`
`181`		`- panic(ErrInvalidRequires)`
`182`		`- }`
`183`	`179`
`184`	`180`	`register.r = append(register.r, r)`
`185`	`181`	`}`