introspection: regenerate UUID if state is empty

samuelkarp · k8s-infra-cherrypick-robot · commit b140792e46e9 · 2024-07-25T22:03:18.000Z
The /var/lib/containerd/io.containerd.grpc.v1.introspection/uuid file stores a UUID to identify the particular containerd daemon responding to requests. The file should either exist with a UUID, or not exist. However, it has been observed that the file can be truncated with 0 bytes, which will then fail to be parsed as a valid UUID. As a defensive practice, detect a 0-length file and overwrite with a new UUID rather than failing. Fixes: #10491 Signed-off-by: Samuel Karp <samuelkarp@google.com>
diff --git a/services/introspection/local.go b/services/introspection/local.go
@@ -163,6 +163,9 @@ func (l *Local) getUUID() (string, error) {
 		}
 		return "", err
 	}
+	if len(data) == 0 {
+		return l.generateUUID()
+	}
 	u := string(data)
 	if _, err := uuid.Parse(u); err != nil {
 		return "", err

Original file line number	Diff line number	Diff line change
`@@ -163,6 +163,9 @@ func (l *Local) getUUID() (string, error) {`
`163`	`163`	`}`
`164`	`164`	`return "", err`
`165`	`165`	`}`
	`166`	`+ if len(data) == 0 {`
	`167`	`+ return l.generateUUID()`
	`168`	`+ }`
`166`	`169`	`u := string(data)`
`167`	`170`	`if _, err := uuid.Parse(u); err != nil {`
`168`	`171`	`return "", err`