ctr: update WritePidFile to use atomicfile

samuelkarp · samuelkarp · commit ab5365222880 · 2023-06-02T16:56:34.000-07:00
Signed-off-by: Samuel Karp &lt;samuelkarp@google.com&gt;
diff --git a/cmd/ctr/commands/commands.go b/cmd/ctr/commands/commands.go
@@ -24,6 +24,8 @@ import (
 	"strings"
 
 	"github.com/containerd/containerd/defaults"
+	"github.com/containerd/containerd/pkg/atomicfile"
+
 	"github.com/urfave/cli"
 )
 
@@ -272,15 +274,14 @@ func WritePidFile(path string, pid int) error {
 	if err != nil {
 		return err
 	}
-	tempPath := filepath.Join(filepath.Dir(path), fmt.Sprintf(".%s", filepath.Base(path)))
-	f, err := os.OpenFile(tempPath, os.O_RDWR|os.O_CREATE|os.O_EXCL|os.O_SYNC, 0666)
+	f, err := atomicfile.New(path, 0o666)
 	if err != nil {
 		return err
 	}
 	_, err = fmt.Fprintf(f, "%d", pid)
-	f.Close()
 	if err != nil {
+		f.Cancel()
 		return err
 	}
-	return os.Rename(tempPath, path)
+	return f.Close()
 }

Original file line number	Diff line number	Diff line change
`@@ -24,6 +24,8 @@ import (`
`24`	`24`	`"strings"`
`25`	`25`
`26`	`26`	`"github.com/containerd/containerd/defaults"`
	`27`	`+ "github.com/containerd/containerd/pkg/atomicfile"`
	`28`	`+`
`27`	`29`	`"github.com/urfave/cli"`
`28`	`30`	`)`
`29`	`31`
`@@ -272,15 +274,14 @@ func WritePidFile(path string, pid int) error {`
`272`	`274`	`if err != nil {`
`273`	`275`	`return err`
`274`	`276`	`}`
`275`		`- tempPath := filepath.Join(filepath.Dir(path), fmt.Sprintf(".%s", filepath.Base(path)))`
`276`		`- f, err := os.OpenFile(tempPath, os.O_RDWR\|os.O_CREATE\|os.O_EXCL\|os.O_SYNC, 0666)`
	`277`	`+ f, err := atomicfile.New(path, 0o666)`
`277`	`278`	`if err != nil {`
`278`	`279`	`return err`
`279`	`280`	`}`
`280`	`281`	`_, err = fmt.Fprintf(f, "%d", pid)`
`281`		`- f.Close()`
`282`	`282`	`if err != nil {`
	`283`	`+ f.Cancel()`
`283`	`284`	`return err`
`284`	`285`	`}`
`285`		`- return os.Rename(tempPath, path)`
	`286`	`+ return f.Close()`
`286`	`287`	`}`