cri: UpdatePodSandbox should return Unimplemented

samuelkarp · samuelkarp · commit a835101036b1 · 2026-03-12T13:27:32.000-07:00
errgrpc will correctly translate ErrNotImplemented to GRPC's
Unimplemented, but a plain error will be returned directly.

Signed-off-by: Samuel Karp &lt;samuelkarp@google.com&gt;
diff --git a/internal/cri/instrument/instrumented_service.go b/internal/cri/instrument/instrumented_service.go
@@ -18,7 +18,6 @@ package instrument
 
 import (
 	"context"
-	"errors"
 
 	"github.com/containerd/errdefs"
 	"github.com/containerd/errdefs/pkg/errgrpc"
@@ -664,5 +663,5 @@ func (in *instrumentedService) RuntimeConfig(ctx context.Context, r *runtime.Run
 }
 
 func (in *instrumentedService) UpdatePodSandboxResources(ctx context.Context, r *runtime.UpdatePodSandboxResourcesRequest) (res *runtime.UpdatePodSandboxResourcesResponse, err error) {
-	return nil, errors.New("not implemented yet")
+	return nil, errgrpc.ToGRPC(errdefs.ErrNotImplemented)
 }

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,6 @@ package instrument`
`18`	`18`
`19`	`19`	`import (`
`20`	`20`	`"context"`
`21`		`- "errors"`
`22`	`21`
`23`	`22`	`"github.com/containerd/errdefs"`
`24`	`23`	`"github.com/containerd/errdefs/pkg/errgrpc"`
`@@ -664,5 +663,5 @@ func (in instrumentedService) RuntimeConfig(ctx context.Context, r runtime.Run`
`664`	`663`	`}`
`665`	`664`
`666`	`665`	`func (in instrumentedService) UpdatePodSandboxResources(ctx context.Context, r runtime.UpdatePodSandboxResourcesRequest) (res *runtime.UpdatePodSandboxResourcesResponse, err error) {`
`667`		`- return nil, errors.New("not implemented yet")`
	`666`	`+ return nil, errgrpc.ToGRPC(errdefs.ErrNotImplemented)`
`668`	`667`	`}`