Fix panic in metadata content writer on copy error

dmcgowan · dmcgowan · commit a4b51d1197ee · 2021-09-23T15:05:39.000-07:00
The `createAndCopy` function is only called when `nw.w` is nil in order to create a new writer and prepare it. The current code is attempting to close `nw.w` when there is a copy error. The correct behavior would be to close the new writer and not touch `nw.w`. Signed-off-by: Derek McGowan <derek@mcg.dev> (cherry picked from commit b9cf0d7) Signed-off-by: Derek McGowan <derek@mcg.dev>
diff --git a/metadata/content.go b/metadata/content.go
@@ -551,13 +551,13 @@ func (nw *namespacedWriter) createAndCopy(ctx context.Context, desc ocispec.Desc
 	if desc.Size > 0 {
 		ra, err := nw.provider.ReaderAt(ctx, nw.desc)
 		if err != nil {
+			w.Close()
 			return err
 		}
 		defer ra.Close()
 
 		if err := content.CopyReaderAt(w, ra, desc.Size); err != nil {
-			nw.w.Close()
-			nw.w = nil
+			w.Close()
 			return err
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -551,13 +551,13 @@ func (nw *namespacedWriter) createAndCopy(ctx context.Context, desc ocispec.Desc`
`551`	`551`	`if desc.Size > 0 {`
`552`	`552`	`ra, err := nw.provider.ReaderAt(ctx, nw.desc)`
`553`	`553`	`if err != nil {`
	`554`	`+ w.Close()`
`554`	`555`	`return err`
`555`	`556`	`}`
`556`	`557`	`defer ra.Close()`
`557`	`558`
`558`	`559`	`if err := content.CopyReaderAt(w, ra, desc.Size); err != nil {`
`559`		`- nw.w.Close()`
`560`		`- nw.w = nil`
	`560`	`+ w.Close()`
`561`	`561`	`return err`
`562`	`562`	`}`
`563`	`563`	`}`