Print elapsed time for image unpack

alakesh · alakesh · commit 9f5244f4101c · 2021-03-09T06:40:49.000Z
The provides additional insight into how much time is being spent in
unpacking and is helpful in performance comparison for just this stage
without resorting to running under time command in linux for example.

Signed-off-by: Alakesh Haloi &lt;alakeshh@amazon.com&gt;
diff --git a/cmd/ctr/commands/images/pull.go b/cmd/ctr/commands/images/pull.go
@@ -19,6 +19,7 @@ package images
 import (
 	"fmt"
 	"net/http/httptrace"
+	"time"
 
 	"github.com/containerd/containerd"
 	"github.com/containerd/containerd/cmd/ctr/commands"
@@ -124,6 +125,7 @@ command. As part of this process, we do the following:
 			p = append(p, platforms.DefaultSpec())
 		}
 
+		start := time.Now()
 		for _, platform := range p {
 			fmt.Printf("unpacking %s %s...\n", platforms.Format(platform), img.Target.Digest)
 			i := containerd.NewImageWithPlatform(client, img, platforms.Only(platform))
@@ -140,8 +142,7 @@ command. As part of this process, we do the following:
 				fmt.Printf("image chain ID: %s\n", chainID)
 			}
 		}
-
-		fmt.Println("done")
+		fmt.Printf("done: %s\t\n", time.Since(start))
 		return nil
 	},
 }

Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,7 @@ package images`
`19`	`19`	`import (`
`20`	`20`	`"fmt"`
`21`	`21`	`"net/http/httptrace"`
	`22`	`+ "time"`
`22`	`23`
`23`	`24`	`"github.com/containerd/containerd"`
`24`	`25`	`"github.com/containerd/containerd/cmd/ctr/commands"`
`@@ -124,6 +125,7 @@ command. As part of this process, we do the following:`
`124`	`125`	`p = append(p, platforms.DefaultSpec())`
`125`	`126`	`}`
`126`	`127`
	`128`	`+ start := time.Now()`
`127`	`129`	`for _, platform := range p {`
`128`	`130`	`fmt.Printf("unpacking %s %s...\n", platforms.Format(platform), img.Target.Digest)`
`129`	`131`	`i := containerd.NewImageWithPlatform(client, img, platforms.Only(platform))`
`@@ -140,8 +142,7 @@ command. As part of this process, we do the following:`
`140`	`142`	`fmt.Printf("image chain ID: %s\n", chainID)`
`141`	`143`	`}`
`142`	`144`	`}`
`143`		`-`
`144`		`- fmt.Println("done")`
	`145`	`+ fmt.Printf("done: %s\t\n", time.Since(start))`
`145`	`146`	`return nil`
`146`	`147`	`},`
`147`	`148`	`}`