Skip to content

Commit 9e85acd

Browse files
committed
go.mod: add warnings about overridden versions
Adding warning comments to go.mod to guide users to the actual version that is used (and tested against). In the "replace" section, adding comments that explain the reason for pinning some of the dependencies to specific versions. Signed-off-by: Sebastiaan van Stijn <[email protected]>
1 parent fef6bb8 commit 9e85acd

1 file changed

Lines changed: 8 additions & 0 deletions

File tree

go.mod

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,10 @@ require (
2727
github.com/docker/go-units v0.4.0
2828
github.com/emicklei/go-restful v2.9.5+incompatible
2929
github.com/fsnotify/fsnotify v1.4.9
30+
// googleapis: the actual version is replaced in replace()
3031
github.com/gogo/googleapis v1.4.0
3132
github.com/gogo/protobuf v1.3.2
33+
// protobuf: the actual version is replaced in replace()
3234
github.com/golang/protobuf v1.4.3
3335
github.com/google/go-cmp v0.5.4
3436
github.com/google/uuid v1.1.2
@@ -48,11 +50,13 @@ require (
4850
github.com/sirupsen/logrus v1.7.0
4951
github.com/stretchr/testify v1.6.1
5052
github.com/tchap/go-patricia v2.2.6+incompatible
53+
// urfave/cli: the actual version is replaced in replace()
5154
github.com/urfave/cli v1.22.2
5255
go.etcd.io/bbolt v1.3.5
5356
golang.org/x/net v0.0.0-20201224014010-6772e930b67b
5457
golang.org/x/sync v0.0.0-20201207232520-09787c993a3a
5558
golang.org/x/sys v0.0.0-20210124154548-22da62e12c0c
59+
// grpc: the actual version is replaced in replace()
5660
google.golang.org/grpc v1.33.2
5761
gotest.tools/v3 v3.0.3
5862
k8s.io/api v0.20.1
@@ -66,10 +70,14 @@ require (
6670
)
6771

6872
replace (
73+
// FIXME gogo/googleapis must be v1.3.2 <BECAUSE>
6974
github.com/gogo/googleapis => github.com/gogo/googleapis v1.3.2
75+
// FIXME golang/protobuf must be v1.3.5 <BECAUSE>
7076
github.com/golang/protobuf => github.com/golang/protobuf v1.3.5
7177
// urfave/cli must be <= v1.22.1 due to a regression: https://github.com/urfave/cli/issues/1092
7278
github.com/urfave/cli => github.com/urfave/cli v1.22.1
79+
// FIXME genproto must be v0.0.0-20200224152610-e50cd9704f63 <BECAUSE>
7380
google.golang.org/genproto => google.golang.org/genproto v0.0.0-20200224152610-e50cd9704f63
81+
// FIXME olang.org/grpc be v1.27.1 <BECAUSE>
7482
google.golang.org/grpc => google.golang.org/grpc v1.27.1
7583
)

0 commit comments

Comments
 (0)