Skip to content

Commit 9e60300

Browse files
committed
snapshots/testsuite: Rename: fix fuse-overlayfs incompatibility
Signed-off-by: Akihiro Suda <[email protected]> (cherry picked from commit 5dbae38) Signed-off-by: Akihiro Suda <[email protected]>
1 parent 1677a17 commit 9e60300

1 file changed

Lines changed: 10 additions & 4 deletions

File tree

snapshots/testsuite/issues.go

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -124,10 +124,16 @@ func checkRename(ss string) func(ctx context.Context, t *testing.T, sn snapshots
124124
)
125125

126126
var applier []fstest.Applier
127-
if ss != "overlayfs" {
128-
// With neither OVERLAY_FS_REDIRECT_DIR nor redirect_dir,
129-
// renaming the directory on the lower directory doesn't work on overlayfs.
130-
// https://github.com/torvalds/linux/blob/v5.18/Documentation/filesystems/overlayfs.rst#renaming-directories
127+
switch ss {
128+
// With neither OVERLAY_FS_REDIRECT_DIR nor redirect_dir,
129+
// renaming the directory on the lower directory doesn't work on overlayfs.
130+
// https://github.com/torvalds/linux/blob/v5.18/Documentation/filesystems/overlayfs.rst#renaming-directories
131+
//
132+
// It doesn't work on fuse-overlayfs either.
133+
// https://github.com/containerd/fuse-overlayfs-snapshotter/pull/53#issuecomment-1543442048
134+
case "overlayfs", "fuse-overlayfs":
135+
// NOP
136+
default:
131137
applier = append(applier, fstest.Rename("/dir1", "/dir2"))
132138
}
133139
applier = append(

0 commit comments

Comments
 (0)