CI: Explicitly upgrade MinGW on Windows 2019 GitHub runners.

aznashwan · akhilerm · commit 9e24388b209e · 2024-03-04T18:14:08.000+05:30
The default version of MinGW and GCC on the GitHub-hosted Windows 2019 runners compile fine but lead to linker errors during runtime. Signed-off-by: Nashwan Azhari <nazhari@cloudbasesolutions.com> (cherry picked from commit c883410) Signed-off-by: Akhil Mohan <akhilerm@gmail.com>
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -195,6 +195,13 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - uses: ./.github/actions/install-go
+
+      # NOTE(aznashwan): starting with Golang 1.21, the windows-2019 GitHub runner's
+      # builtin MinGW version leads to DLL loading errors during runtime.
+      - name: Upgrade MinGW on Windows 2019
+        if: matrix.os == 'windows-2019'
+        run: choco upgrade mingw
+
       - name: Make
         run: |
           make build
@@ -244,6 +251,12 @@ jobs:
 
       - run: script/setup/install-dev-tools
 
+      # NOTE(aznashwan): starting with Golang 1.21, the windows-2019 GitHub runner's
+      # builtin MinGW version leads to DLL loading errors during runtime.
+      - name: Upgrade MinGW on Windows 2019
+        if: matrix.os == 'windows-2019'
+        run: choco upgrade mingw
+
       - name: Binaries
         env:
           CGO_ENABLED: 1
