Handle windows signals

crosbymichael · crosbymichael · commit 9d72b4543b57 · 2018-07-26T11:24:20.000-04:00
Since windows does not require a signal handler, we just block on the
channel forever so that it does not exit.

Signed-off-by: Michael Crosby &lt;crosbymichael@gmail.com&gt;
diff --git a/runtime/v2/shim/shim_windows.go b/runtime/v2/shim/shim_windows.go
@@ -37,7 +37,6 @@ import (
 // setupSignals creates a new signal handler for all signals
 func setupSignals() (chan os.Signal, error) {
 	signals := make(chan os.Signal, 32)
-	// TODO: JTERRY75: Make this based on events.
 	return signals, nil
 }
 
@@ -67,7 +66,7 @@ func serveListener(path string) (net.Listener, string, error) {
 }
 
 func handleSignals(logger *logrus.Entry, signals chan os.Signal) error {
-	// TODO: JTERRY75: Make this based on events?
+	<-signals
 	return nil
 }
 

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,6 @@ import (`
`37`	`37`	`// setupSignals creates a new signal handler for all signals`
`38`	`38`	`func setupSignals() (chan os.Signal, error) {`
`39`	`39`	`signals := make(chan os.Signal, 32)`
`40`		`- // TODO: JTERRY75: Make this based on events.`
`41`	`40`	`return signals, nil`
`42`	`41`	`}`
`43`	`42`
`@@ -67,7 +66,7 @@ func serveListener(path string) (net.Listener, string, error) {`
`67`	`66`	`}`
`68`	`67`
`69`	`68`	`func handleSignals(logger *logrus.Entry, signals chan os.Signal) error {`
`70`		`- // TODO: JTERRY75: Make this based on events?`
	`69`	`+ <-signals`
`71`	`70`	`return nil`
`72`	`71`	`}`
`73`	`72`