Skip to content

Commit 9b882c4

Browse files
Merge pull request #3000 from stefanberger/descriptor_annotations.pr
Add missing annotations map to Descriptor for gRPC transfer
2 parents 8ea28ff + 09cf2a6 commit 9b882c4

15 files changed

Lines changed: 440 additions & 66 deletions

File tree

api/next.pb.txt

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1771,6 +1771,34 @@ file {
17711771
type: TYPE_INT64
17721772
json_name: "size"
17731773
}
1774+
field {
1775+
name: "annotations"
1776+
number: 5
1777+
label: LABEL_REPEATED
1778+
type: TYPE_MESSAGE
1779+
type_name: ".containerd.types.Descriptor.AnnotationsEntry"
1780+
json_name: "annotations"
1781+
}
1782+
nested_type {
1783+
name: "AnnotationsEntry"
1784+
field {
1785+
name: "key"
1786+
number: 1
1787+
label: LABEL_OPTIONAL
1788+
type: TYPE_STRING
1789+
json_name: "key"
1790+
}
1791+
field {
1792+
name: "value"
1793+
number: 2
1794+
label: LABEL_OPTIONAL
1795+
type: TYPE_STRING
1796+
json_name: "value"
1797+
}
1798+
options {
1799+
map_entry: true
1800+
}
1801+
}
17741802
}
17751803
options {
17761804
go_package: "github.com/containerd/containerd/api/types;types"

api/types/descriptor.pb.go

Lines changed: 175 additions & 14 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

api/types/descriptor.proto

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,4 +15,5 @@ message Descriptor {
1515
string media_type = 1;
1616
string digest = 2 [(gogoproto.customtype) = "github.com/opencontainers/go-digest.Digest", (gogoproto.nullable) = false];
1717
int64 size = 3;
18+
map<string, string> annotations = 5;
1819
}

container_checkpoint_opts.go

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,10 +70,11 @@ func WithCheckpointTask(ctx context.Context, client *Client, c *containers.Conta
7070
for _, d := range task.Descriptors {
7171
platformSpec := platforms.DefaultSpec()
7272
index.Manifests = append(index.Manifests, imagespec.Descriptor{
73-
MediaType: d.MediaType,
74-
Size: d.Size_,
75-
Digest: d.Digest,
76-
Platform: &platformSpec,
73+
MediaType: d.MediaType,
74+
Size: d.Size_,
75+
Digest: d.Digest,
76+
Platform: &platformSpec,
77+
Annotations: d.Annotations,
7778
})
7879
}
7980
// save copts

diff.go

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -80,17 +80,19 @@ func (r *diffRemote) Compare(ctx context.Context, a, b []mount.Mount, opts ...di
8080

8181
func toDescriptor(d *types.Descriptor) ocispec.Descriptor {
8282
return ocispec.Descriptor{
83-
MediaType: d.MediaType,
84-
Digest: d.Digest,
85-
Size: d.Size_,
83+
MediaType: d.MediaType,
84+
Digest: d.Digest,
85+
Size: d.Size_,
86+
Annotations: d.Annotations,
8687
}
8788
}
8889

8990
func fromDescriptor(d ocispec.Descriptor) *types.Descriptor {
9091
return &types.Descriptor{
91-
MediaType: d.MediaType,
92-
Digest: d.Digest,
93-
Size_: d.Size,
92+
MediaType: d.MediaType,
93+
Digest: d.Digest,
94+
Size_: d.Size,
95+
Annotations: d.Annotations,
9496
}
9597
}
9698

image_store.go

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -137,16 +137,18 @@ func imagesFromProto(imagespb []imagesapi.Image) []images.Image {
137137

138138
func descFromProto(desc *types.Descriptor) ocispec.Descriptor {
139139
return ocispec.Descriptor{
140-
MediaType: desc.MediaType,
141-
Size: desc.Size_,
142-
Digest: desc.Digest,
140+
MediaType: desc.MediaType,
141+
Size: desc.Size_,
142+
Digest: desc.Digest,
143+
Annotations: desc.Annotations,
143144
}
144145
}
145146

146147
func descToProto(desc *ocispec.Descriptor) types.Descriptor {
147148
return types.Descriptor{
148-
MediaType: desc.MediaType,
149-
Size_: desc.Size,
150-
Digest: desc.Digest,
149+
MediaType: desc.MediaType,
150+
Size_: desc.Size,
151+
Digest: desc.Digest,
152+
Annotations: desc.Annotations,
151153
}
152154
}

0 commit comments

Comments
 (0)