lint: silence "SA1019: tar.TypeRegA has been deprecated... (staticheck)"

AkihiroSuda · AkihiroSuda · commit 9b510e9a8fc4 · 2023-02-16T03:50:23.000+09:00
"SA1019: tar.TypeRegA has been deprecated since Go 1.11 and an alternative has been available since Go 1.1:
Use TypeReg instead. (staticcheck)"

Signed-off-by: Akihiro Suda &lt;akihiro.suda.cz@hco.ntt.co.jp&gt;
diff --git a/archive/tar.go b/archive/tar.go
@@ -341,6 +341,7 @@ func createTarFile(ctx context.Context, path, extractDir string, hdr *tar.Header
 			}
 		}
 
+	//nolint:staticcheck // TypeRegA is deprecated but we may still receive an external tar with TypeRegA
 	case tar.TypeReg, tar.TypeRegA:
 		file, err := openFile(path, os.O_WRONLY|os.O_CREATE|os.O_TRUNC, hdrInfo.Mode())
 		if err != nil {
diff --git a/images/archive/importer.go b/images/archive/importer.go
@@ -95,6 +95,7 @@ func ImportIndex(ctx context.Context, store content.Store, reader io.Reader, opt
 			symlinks[hdr.Name] = path.Join(path.Dir(hdr.Name), hdr.Linkname)
 		}
 
+		//nolint:staticcheck // TypeRegA is deprecated but we may still receive an external tar with TypeRegA
 		if hdr.Typeflag != tar.TypeReg && hdr.Typeflag != tar.TypeRegA {
 			if hdr.Typeflag != tar.TypeDir {
 				log.G(ctx).WithField("file", hdr.Name).Debug("file type ignored")

Original file line number	Diff line number	Diff line change
`@@ -341,6 +341,7 @@ func createTarFile(ctx context.Context, path, extractDir string, hdr *tar.Header`
`341`	`341`	`}`
`342`	`342`	`}`
`343`	`343`
	`344`	`+ //nolint:staticcheck // TypeRegA is deprecated but we may still receive an external tar with TypeRegA`
`344`	`345`	`case tar.TypeReg, tar.TypeRegA:`
`345`	`346`	`file, err := openFile(path, os.O_WRONLY\|os.O_CREATE\|os.O_TRUNC, hdrInfo.Mode())`
`346`	`347`	`if err != nil {`
Original file line number	Diff line number	Diff line change
`@@ -95,6 +95,7 @@ func ImportIndex(ctx context.Context, store content.Store, reader io.Reader, opt`
`95`	`95`	`symlinks[hdr.Name] = path.Join(path.Dir(hdr.Name), hdr.Linkname)`
`96`	`96`	`}`
`97`	`97`
	`98`	`+ //nolint:staticcheck // TypeRegA is deprecated but we may still receive an external tar with TypeRegA`
`98`	`99`	`if hdr.Typeflag != tar.TypeReg && hdr.Typeflag != tar.TypeRegA {`
`99`	`100`	`if hdr.Typeflag != tar.TypeDir {`
`100`	`101`	`log.G(ctx).WithField("file", hdr.Name).Debug("file type ignored")`