cri: stop recommending disable_cgroup

AkihiroSuda · AkihiroSuda · commit 8ffb03d689da · 2023-09-29T23:08:00.000+09:00
Disabling cgroup is no longer needed since cgroup v2

Signed-off-by: Akihiro Suda &lt;akihiro.suda.cz@hco.ntt.co.jp&gt;
diff --git a/pkg/cri/sbserver/service_linux.go b/pkg/cri/sbserver/service_linux.go
@@ -35,8 +35,8 @@ const networkAttachCount = 2
 // initPlatform handles linux specific initialization for the CRI service.
 func (c *criService) initPlatform() (err error) {
 	if userns.RunningInUserNS() {
-		if !(c.config.DisableCgroup && !c.apparmorEnabled() && c.config.RestrictOOMScoreAdj) {
-			log.L.Warn("Running containerd in a user namespace typically requires disable_cgroup, disable_apparmor, restrict_oom_score_adj set to be true")
+		if c.apparmorEnabled() || !c.config.RestrictOOMScoreAdj {
+			log.L.Warn("Running CRI plugin in a user namespace typically requires disable_apparmor and restrict_oom_score_adj to be true")
 		}
 	}
 
diff --git a/pkg/cri/server/service_linux.go b/pkg/cri/server/service_linux.go
@@ -34,8 +34,8 @@ const networkAttachCount = 2
 // initPlatform handles linux specific initialization for the CRI service.
 func (c *criService) initPlatform() (err error) {
 	if userns.RunningInUserNS() {
-		if !(c.config.DisableCgroup && !c.apparmorEnabled() && c.config.RestrictOOMScoreAdj) {
-			log.L.Warn("Running containerd in a user namespace typically requires disable_cgroup, disable_apparmor, restrict_oom_score_adj set to be true")
+		if c.apparmorEnabled() || !c.config.RestrictOOMScoreAdj {
+			log.L.Warn("Running CRI plugin in a user namespace typically requires disable_apparmor and restrict_oom_score_adj to be true")
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -35,8 +35,8 @@ const networkAttachCount = 2`
`35`	`35`	`// initPlatform handles linux specific initialization for the CRI service.`
`36`	`36`	`func (c *criService) initPlatform() (err error) {`
`37`	`37`	`if userns.RunningInUserNS() {`
`38`		`- if !(c.config.DisableCgroup && !c.apparmorEnabled() && c.config.RestrictOOMScoreAdj) {`
`39`		`- log.L.Warn("Running containerd in a user namespace typically requires disable_cgroup, disable_apparmor, restrict_oom_score_adj set to be true")`
	`38`	`+ if c.apparmorEnabled() \|\| !c.config.RestrictOOMScoreAdj {`
	`39`	`+ log.L.Warn("Running CRI plugin in a user namespace typically requires disable_apparmor and restrict_oom_score_adj to be true")`
`40`	`40`	`}`
`41`	`41`	`}`
`42`	`42`
Original file line number	Diff line number	Diff line change
`@@ -34,8 +34,8 @@ const networkAttachCount = 2`
`34`	`34`	`// initPlatform handles linux specific initialization for the CRI service.`
`35`	`35`	`func (c *criService) initPlatform() (err error) {`
`36`	`36`	`if userns.RunningInUserNS() {`
`37`		`- if !(c.config.DisableCgroup && !c.apparmorEnabled() && c.config.RestrictOOMScoreAdj) {`
`38`		`- log.L.Warn("Running containerd in a user namespace typically requires disable_cgroup, disable_apparmor, restrict_oom_score_adj set to be true")`
	`37`	`+ if c.apparmorEnabled() \|\| !c.config.RestrictOOMScoreAdj {`
	`38`	`+ log.L.Warn("Running CRI plugin in a user namespace typically requires disable_apparmor and restrict_oom_score_adj to be true")`
`39`	`39`	`}`
`40`	`40`	`}`
`41`	`41`