Fix transfer service dependencies:

kiashok · kiashok · commit 823e0420eb3c · 2023-08-15T15:32:51.000-07:00
- Fill OSVersion field of ocispec.Platform for windows OS in
transfer service plugin init()
- Do not return error from transfer service ReceiveStream if
stream.Recv() returned context.Canceled error

Signed-off-by: Kirtana Ashok &lt;kiashok@microsoft.com&gt;
diff --git a/pkg/transfer/streaming/stream.go b/pkg/transfer/streaming/stream.go
@@ -164,7 +164,7 @@ func ReceiveStream(ctx context.Context, stream streaming.Stream) io.Reader {
 			}
 			anyType, err := stream.Recv()
 			if err != nil {
-				if errors.Is(err, io.EOF) {
+				if errors.Is(err, io.EOF) || errors.Is(err, context.Canceled) {
 					err = nil
 				} else {
 					err = fmt.Errorf("received failed: %w", err)
diff --git a/platforms/platforms.go b/platforms/platforms.go
@@ -213,6 +213,10 @@ func Parse(specifier string) (specs.Platform, error) {
 				p.Variant = cpuVariant()
 			}
 
+			if p.OS == "windows" {
+				p.OSVersion = GetWindowsOsVersion()
+			}
+
 			return p, nil
 		}
 
@@ -235,6 +239,10 @@ func Parse(specifier string) (specs.Platform, error) {
 			p.Variant = ""
 		}
 
+		if p.OS == "windows" {
+			p.OSVersion = GetWindowsOsVersion()
+		}
+
 		return p, nil
 	case 3:
 		// we have a fully specified variant, this is rare
@@ -244,6 +252,10 @@ func Parse(specifier string) (specs.Platform, error) {
 			p.Variant = "v8"
 		}
 
+		if p.OS == "windows" {
+			p.OSVersion = GetWindowsOsVersion()
+		}
+
 		return p, nil
 	}
 
diff --git a/platforms/platforms_other.go b/platforms/platforms_other.go
@@ -28,3 +28,7 @@ func newDefaultMatcher(platform specs.Platform) Matcher {
 		Platform: Normalize(platform),
 	}
 }
+
+func GetWindowsOsVersion() string {
+	return ""
+}
diff --git a/platforms/platforms_windows.go b/platforms/platforms_windows.go
@@ -17,7 +17,10 @@
 package platforms
 
 import (
+	"fmt"
+
 	specs "github.com/opencontainers/image-spec/specs-go/v1"
+	"golang.org/x/sys/windows"
 )
 
 // NewMatcher returns a Windows matcher that will match on osVersionPrefix if
@@ -32,3 +35,8 @@ func newDefaultMatcher(platform specs.Platform) Matcher {
 		},
 	}
 }
+
+func GetWindowsOsVersion() string {
+	major, minor, build := windows.RtlGetNtVersionNumbers()
+	return fmt.Sprintf("%d.%d.%d", major, minor, build)
+}

Original file line number	Diff line number	Diff line change
`@@ -164,7 +164,7 @@ func ReceiveStream(ctx context.Context, stream streaming.Stream) io.Reader {`
`164`	`164`	`}`
`165`	`165`	`anyType, err := stream.Recv()`
`166`	`166`	`if err != nil {`
`167`		`- if errors.Is(err, io.EOF) {`
	`167`	`+ if errors.Is(err, io.EOF) \|\| errors.Is(err, context.Canceled) {`
`168`	`168`	`err = nil`
`169`	`169`	`} else {`
`170`	`170`	`err = fmt.Errorf("received failed: %w", err)`
Original file line number	Diff line number	Diff line change
`@@ -213,6 +213,10 @@ func Parse(specifier string) (specs.Platform, error) {`
`213`	`213`	`p.Variant = cpuVariant()`
`214`	`214`	`}`
`215`	`215`
	`216`	`+ if p.OS == "windows" {`
	`217`	`+ p.OSVersion = GetWindowsOsVersion()`
	`218`	`+ }`
	`219`	`+`
`216`	`220`	`return p, nil`
`217`	`221`	`}`
`218`	`222`
`@@ -235,6 +239,10 @@ func Parse(specifier string) (specs.Platform, error) {`
`235`	`239`	`p.Variant = ""`
`236`	`240`	`}`
`237`	`241`
	`242`	`+ if p.OS == "windows" {`
	`243`	`+ p.OSVersion = GetWindowsOsVersion()`
	`244`	`+ }`
	`245`	`+`
`238`	`246`	`return p, nil`
`239`	`247`	`case 3:`
`240`	`248`	`// we have a fully specified variant, this is rare`
`@@ -244,6 +252,10 @@ func Parse(specifier string) (specs.Platform, error) {`
`244`	`252`	`p.Variant = "v8"`
`245`	`253`	`}`
`246`	`254`
	`255`	`+ if p.OS == "windows" {`
	`256`	`+ p.OSVersion = GetWindowsOsVersion()`
	`257`	`+ }`
	`258`	`+`
`247`	`259`	`return p, nil`
`248`	`260`	`}`
`249`	`261`
Original file line number	Diff line number	Diff line change
`@@ -28,3 +28,7 @@ func newDefaultMatcher(platform specs.Platform) Matcher {`
`28`	`28`	`Platform: Normalize(platform),`
`29`	`29`	`}`
`30`	`30`	`}`
	`31`	`+`
	`32`	`+func GetWindowsOsVersion() string {`
	`33`	`+ return ""`
	`34`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,10 @@`
`17`	`17`	`package platforms`
`18`	`18`
`19`	`19`	`import (`
	`20`	`+ "fmt"`
	`21`	`+`
`20`	`22`	`specs "github.com/opencontainers/image-spec/specs-go/v1"`
	`23`	`+ "golang.org/x/sys/windows"`
`21`	`24`	`)`
`22`	`25`
`23`	`26`	`// NewMatcher returns a Windows matcher that will match on osVersionPrefix if`
`@@ -32,3 +35,8 @@ func newDefaultMatcher(platform specs.Platform) Matcher {`
`32`	`35`	`},`
`33`	`36`	`}`
`34`	`37`	`}`
	`38`	`+`
	`39`	`+func GetWindowsOsVersion() string {`
	`40`	`+ major, minor, build := windows.RtlGetNtVersionNumbers()`
	`41`	`+ return fmt.Sprintf("%d.%d.%d", major, minor, build)`
	`42`	`+}`