cri: add deprecation warning for rutnime_engine

samuelkarp · samuelkarp · commit 8040e74bf8e6 · 2023-12-05T22:28:07.000-08:00
Signed-off-by: Samuel Karp &lt;samuelkarp@google.com&gt;
diff --git a/pkg/cri/config/config.go b/pkg/cri/config/config.go
@@ -473,6 +473,7 @@ func ValidatePluginConfig(ctx context.Context, c *PluginConfig) ([]deprecation.W
 			if r.Type != plugin.RuntimeLinuxV1 {
 				return warnings, fmt.Errorf("`runtime_engine` only works for runtime %s", plugin.RuntimeLinuxV1)
 			}
+			warnings = append(warnings, deprecation.CRIRuntimeEngine)
 			log.G(ctx).Warning("`runtime_engine` is deprecated, please use runtime `options` instead")
 		}
 		if r.Root != "" {
diff --git a/pkg/cri/config/config_test.go b/pkg/cri/config/config_test.go
@@ -227,6 +227,7 @@ func TestValidateConfig(t *testing.T) {
 					},
 				},
 			},
+			warnings: []deprecation.Warning{deprecation.CRIRuntimeEngine},
 		},
 		"deprecated runtime_engine for v2 runtime": {
 			config: &PluginConfig{
diff --git a/pkg/deprecation/deprecation.go b/pkg/deprecation/deprecation.go
@@ -31,6 +31,8 @@ const (
 	CRIUntrustedWorkloadRuntime Warning = Prefix + "cri-untrusted-workload-runtime"
 	// CRIDefaultRuntime is a warning for the `default_runtime` property
 	CRIDefaultRuntime Warning = Prefix + "cri-default-runtime"
+	// CRIRuntimeEngine is a warning for the `runtime_engine` property
+	CRIRuntimeEngine Warning = Prefix + "cri-runtime-engine"
 	// CRIRegistryMirrors is a warning for the use of the `mirrors` property
 	CRIRegistryMirrors Warning = Prefix + "cri-registry-mirrors"
 	// CRIRegistryAuths is a warning for the use of the `auths` property
@@ -57,6 +59,8 @@ var messages = map[Warning]string{
 		"Create an `untrusted` runtime in `runtimes` instead.",
 	CRIDefaultRuntime: "The `default_runtime` property of [plugins.\"io.containerd.grpc.v1.cri\".containerd] is deprecated since containerd v1.3 and will be removed in containerd v2.0. " +
 		"Use `default_runtime_name` instead.",
+	CRIRuntimeEngine: "The `runtime_engine` property of [plugins.\"io.containerd.grpc.v1.cri\".containerd.runtimes.*] is deprecated since containerd v1.3 and will be removed in containerd v2.0. " +
+		"Use a v2 runtime and `options` instead.",
 	CRIRegistryMirrors: "The `mirrors` property of `[plugins.\"io.containerd.grpc.v1.cri\".registry]` is deprecated since containerd v1.5 and will be removed in containerd v2.0." +
 		"Use `config_path` instead.",
 	CRIRegistryAuths: "The `auths` property of `[plugins.\"io.containerd.grpc.v1.cri\".registry]` is deprecated since containerd v1.3 and will be removed in containerd v2.0." +

Original file line number	Diff line number	Diff line change
`@@ -473,6 +473,7 @@ func ValidatePluginConfig(ctx context.Context, c *PluginConfig) ([]deprecation.W`
`473`	`473`	`if r.Type != plugin.RuntimeLinuxV1 {`
`474`	`474`	return warnings, fmt.Errorf("`runtime_engine` only works for runtime %s", plugin.RuntimeLinuxV1)
`475`	`475`	`}`
	`476`	`+ warnings = append(warnings, deprecation.CRIRuntimeEngine)`
`476`	`477`	log.G(ctx).Warning("`runtime_engine` is deprecated, please use runtime `options` instead")
`477`	`478`	`}`
`478`	`479`	`if r.Root != "" {`