Skip TLS verification for localhost

adisky · adisky · commit 8014d9fee0e2 · 2021-05-03T10:21:54.000+05:30
Signed-off-by: Aditi Sharma &lt;adi.sky17@gmail.com&gt;
diff --git a/pkg/cri/server/image_pull.go b/pkg/cri/server/image_pull.go
@@ -337,6 +337,9 @@ func (c *criService) registryHosts(auth *runtime.AuthConfig) docker.RegistryHost
 				if err != nil {
 					return nil, errors.Wrapf(err, "get TLSConfig for registry %q", e)
 				}
+			} else if isLocalHost(host) && u.Scheme == "http" {
+				// Skipping TLS verification for localhost
+				transport.TLSClientConfig.InsecureSkipVerify = true
 			}
 
 			if auth == nil && config.Auth != nil {
@@ -366,13 +369,24 @@ func (c *criService) registryHosts(auth *runtime.AuthConfig) docker.RegistryHost
 
 // defaultScheme returns the default scheme for a registry host.
 func defaultScheme(host string) string {
+	if isLocalHost(host) {
+		return "http"
+	}
+	return "https"
+}
+
+// isLocalHost checks if the registry host is local.
+func isLocalHost(host string) bool {
 	if h, _, err := net.SplitHostPort(host); err == nil {
 		host = h
 	}
-	if host == "localhost" || host == "127.0.0.1" || host == "::1" {
-		return "http"
+
+	if host == "localhost" {
+		return true
 	}
-	return "https"
+
+	ip := net.ParseIP(host)
+	return ip.IsLoopback()
 }
 
 // addDefaultScheme returns the endpoint with default scheme
