Merge pull request #3496 from darfux/v2_close_ttrpc_when_delete

fuweid · web-flow · commit 7fddefc4938f · 2019-08-06T23:51:02.000+08:00
v2: Close ttrpc connection when Delete()
diff --git a/runtime/v2/shim.go b/runtime/v2/shim.go
@@ -221,6 +221,7 @@ func (s *shim) Delete(ctx context.Context) (*runtime.Exit, error) {
 	if err := s.waitShutdown(ctx); err != nil {
 		log.G(ctx).WithError(err).Error("failed to shutdown shim")
 	}
+	s.Close()
 	if err := s.bundle.Delete(); err != nil {
 		log.G(ctx).WithError(err).Error("failed to delete bundle")
 	}

Original file line number	Diff line number	Diff line change
`@@ -221,6 +221,7 @@ func (s shim) Delete(ctx context.Context) (runtime.Exit, error) {`
`221`	`221`	`if err := s.waitShutdown(ctx); err != nil {`
`222`	`222`	`log.G(ctx).WithError(err).Error("failed to shutdown shim")`
`223`	`223`	`}`
	`224`	`+ s.Close()`
`224`	`225`	`if err := s.bundle.Delete(); err != nil {`
`225`	`226`	`log.G(ctx).WithError(err).Error("failed to delete bundle")`
`226`	`227`	`}`