runc-shim: remove misleading comment

laurazard · laurazard · commit 7f3bf993d64c · 2024-08-29T13:04:22.000+01:00
It's not true that `s.mu` needs to be held when calling `handleProcessExit`, and indeed hasn't been the case for a while – see 892dc54. Signed-off-by: Laura Brehm <laurabrehm@hey.com>
diff --git a/cmd/containerd-shim-runc-v2/task/service.go b/cmd/containerd-shim-runc-v2/task/service.go
@@ -707,7 +707,6 @@ func (s *service) send(evt interface{}) {
 	s.events <- evt
 }
 
-// s.mu must be locked when calling handleProcessExit
 func (s *service) handleProcessExit(e runcC.Exit, c *runc.Container, p process.Process) {
 	if ip, ok := p.(*process.Init); ok {
 		// Ensure all children are killed

Original file line number	Diff line number	Diff line change
`@@ -707,7 +707,6 @@ func (s *service) send(evt interface{}) {`
`707`	`707`	`s.events <- evt`
`708`	`708`	`}`
`709`	`709`
`710`		`-// s.mu must be locked when calling handleProcessExit`
`711`	`710`	`func (s service) handleProcessExit(e runcC.Exit, c runc.Container, p process.Process) {`
`712`	`711`	`if ip, ok := p.(*process.Init); ok {`
`713`	`712`	`// Ensure all children are killed`