Fix linter warnings

mxpv · thaJeztah · commit 7db9d1f76ffc · 2022-10-05T00:00:42.000+02:00
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com> (cherry picked from commit 3a3f43f) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
diff --git a/pkg/cri/store/container/status_test.go b/pkg/cri/store/container/status_test.go
@@ -132,8 +132,7 @@ func TestStatus(t *testing.T) {
 
 	t.Logf("failed update should not take effect")
 	err = s.Update(func(o Status) (Status, error) {
-		o = updateStatus
-		return o, updateErr
+		return updateStatus, updateErr
 	})
 	assert.Equal(updateErr, err)
 	assert.Equal(testStatus, s.Get())
@@ -143,8 +142,7 @@ func TestStatus(t *testing.T) {
 
 	t.Logf("successful update should take effect but not checkpoint")
 	err = s.Update(func(o Status) (Status, error) {
-		o = updateStatus
-		return o, nil
+		return updateStatus, nil
 	})
 	assert.NoError(err)
 	assert.Equal(updateStatus, s.Get())
@@ -153,14 +151,12 @@ func TestStatus(t *testing.T) {
 	assert.Equal(testStatus, loaded)
 	// Recover status.
 	assert.NoError(s.Update(func(o Status) (Status, error) {
-		o = testStatus
-		return o, nil
+		return testStatus, nil
 	}))
 
 	t.Logf("failed update sync should not take effect")
 	err = s.UpdateSync(func(o Status) (Status, error) {
-		o = updateStatus
-		return o, updateErr
+		return updateStatus, updateErr
 	})
 	assert.Equal(updateErr, err)
 	assert.Equal(testStatus, s.Get())
@@ -170,8 +166,7 @@ func TestStatus(t *testing.T) {
 
 	t.Logf("successful update sync should take effect and checkpoint")
 	err = s.UpdateSync(func(o Status) (Status, error) {
-		o = updateStatus
-		return o, nil
+		return updateStatus, nil
 	})
 	assert.NoError(err)
 	assert.Equal(updateStatus, s.Get())
diff --git a/pkg/cri/store/sandbox/status_test.go b/pkg/cri/store/sandbox/status_test.go
@@ -45,16 +45,14 @@ func TestStatus(t *testing.T) {
 
 	t.Logf("failed update should not take effect")
 	err := s.Update(func(o Status) (Status, error) {
-		o = updateStatus
-		return o, updateErr
+		return updateStatus, updateErr
 	})
 	assert.Equal(updateErr, err)
 	assert.Equal(testStatus, s.Get())
 
 	t.Logf("successful update should take effect but not checkpoint")
 	err = s.Update(func(o Status) (Status, error) {
-		o = updateStatus
-		return o, nil
+		return updateStatus, nil
 	})
 	assert.NoError(err)
 	assert.Equal(updateStatus, s.Get())
