Merge pull request #3414 from estesp/refactor-forloop

dmcgowan · web-flow · commit 7d03fc63e186 · 2019-07-15T11:19:48.000-07:00
Small refactor due to CI linter changes
diff --git a/cmd/ctr/commands/events/events.go b/cmd/ctr/commands/events/events.go
@@ -42,8 +42,7 @@ var Command = cli.Command{
 		defer cancel()
 		eventsClient := client.EventService()
 		eventsCh, errCh := eventsClient.Subscribe(ctx, context.Args()...)
-		open := true
-		for open {
+		for {
 			var e *events.Envelope
 			select {
 			case e = <-eventsCh:
@@ -72,6 +71,5 @@ var Command = cli.Command{
 				}
 			}
 		}
-		return nil
 	},
 }

Original file line number	Diff line number	Diff line change
`@@ -42,8 +42,7 @@ var Command = cli.Command{`
`42`	`42`	`defer cancel()`
`43`	`43`	`eventsClient := client.EventService()`
`44`	`44`	`eventsCh, errCh := eventsClient.Subscribe(ctx, context.Args()...)`
`45`		`- open := true`
`46`		`- for open {`
	`45`	`+ for {`
`47`	`46`	`var e *events.Envelope`
`48`	`47`	`select {`
`49`	`48`	`case e = <-eventsCh:`
`@@ -72,6 +71,5 @@ var Command = cli.Command{`
`72`	`71`	`}`
`73`	`72`	`}`
`74`	`73`	`}`
`75`		`- return nil`
`76`	`74`	`},`
`77`	`75`	`}`