pkg/reference: Spec.String(): use string-concatenation instead of sprintf

thaJeztah · thaJeztah · commit 799bca97f2dd · 2024-06-27T12:04:22.000+02:00
These were straight concatenations of strings; reduce some allocations by
removing fmt.Sprintf for this.

Signed-off-by: Sebastiaan van Stijn &lt;github@gone.nl&gt;
diff --git a/pkg/reference/reference.go b/pkg/reference/reference.go
@@ -18,7 +18,6 @@ package reference
 
 import (
 	"errors"
-	"fmt"
 	"net/url"
 	"path"
 	"regexp"
@@ -146,10 +145,10 @@ func (r Spec) String() string {
 		return r.Locator
 	}
 	if r.Object[:1] == "@" {
-		return fmt.Sprintf("%v%v", r.Locator, r.Object)
+		return r.Locator + r.Object
 	}
 
-	return fmt.Sprintf("%v:%v", r.Locator, r.Object)
+	return r.Locator + ":" + r.Object
 }
 
 // SplitObject provides two parts of the object spec, delimited by an `@`

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,6 @@ package reference`
`18`	`18`
`19`	`19`	`import (`
`20`	`20`	`"errors"`
`21`		`- "fmt"`
`22`	`21`	`"net/url"`
`23`	`22`	`"path"`
`24`	`23`	`"regexp"`
`@@ -146,10 +145,10 @@ func (r Spec) String() string {`
`146`	`145`	`return r.Locator`
`147`	`146`	`}`
`148`	`147`	`if r.Object[:1] == "@" {`
`149`		`- return fmt.Sprintf("%v%v", r.Locator, r.Object)`
	`148`	`+ return r.Locator + r.Object`
`150`	`149`	`}`
`151`	`150`
`152`		`- return fmt.Sprintf("%v:%v", r.Locator, r.Object)`
	`151`	`+ return r.Locator + ":" + r.Object`
`153`	`152`	`}`
`154`	`153`
`155`	`154`	// SplitObject provides two parts of the object spec, delimited by an `@`