Skip to content

Commit 7300296

Browse files
committed
reverts removal of parallel run from critest
Signed-off-by: Paul S. Schweigert <[email protected]> As discussed in #6903, running ginkgo tests in parallel while trying to skip wasn't working. However, now that kubernetes-sigs/cri-tools#930 has fixed the issue upstream, we can revert back to running our tests in parallel with the skip.
1 parent 9aa6725 commit 7300296

3 files changed

Lines changed: 3 additions & 4 deletions

File tree

Vagrantfile

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -271,8 +271,7 @@ EOF
271271
fi
272272
trap cleanup EXIT
273273
ctr version
274-
# TODO run in parallel, see https://github.com/containerd/containerd/issues/6903
275-
critest --ginkgo.skip='HostIpc is true' --report-dir="${REPORT_DIR}"
274+
critest --parallel=$[$(nproc)+2] --ginkgo.skip='HostIpc is true' --report-dir="${REPORT_DIR}"
276275
SHELL
277276
end
278277

script/setup/critools-version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
v1.24.0
1+
v1.24.1

script/setup/install-critools

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ set -eu -o pipefail
2323
script_dir="$(cd -- "$(dirname -- "$0")" > /dev/null 2>&1; pwd -P)"
2424

2525
cd "$(go env GOPATH)"
26-
go install github.com/onsi/ginkgo/ginkgo@v1.16.5
26+
go install github.com/onsi/ginkgo/v2/ginkgo@v2.1.4
2727

2828
: "${CRITEST_COMMIT:=$(cat "${script_dir}/critools-version")}"
2929
: "${DESTDIR:=""}"

0 commit comments

Comments
 (0)