cri: Expose userns in PodSandboxStatus rpc

rata · rata · commit 6e809ef13a60 · 2024-02-28T11:38:09.000-03:00
We added support for userns but we weren't showing it in the podSandboxStatus. Let's just show the whole nsOpts, so we don't forget in the future either if something else inside there changes. Please note that this will expose the content of nsOpts.TargetId that we weren't exposing before. But that seemed like a bug to me. The cherry-pick has been amended to do the change in cri/sbserver and cri/server. Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com> (cherry picked from commit 6c356a5)
diff --git a/pkg/cri/sbserver/sandbox_status.go b/pkg/cri/sbserver/sandbox_status.go
@@ -104,11 +104,7 @@ func toCRISandboxStatus(meta sandboxstore.Metadata, status string, createdAt tim
 		},
 		Linux: &runtime.LinuxPodSandboxStatus{
 			Namespaces: &runtime.Namespace{
-				Options: &runtime.NamespaceOption{
-					Network: nsOpts.GetNetwork(),
-					Pid:     nsOpts.GetPid(),
-					Ipc:     nsOpts.GetIpc(),
-				},
+				Options: nsOpts,
 			},
 		},
 		Labels:         meta.Config.GetLabels(),
diff --git a/pkg/cri/server/sandbox_status.go b/pkg/cri/server/sandbox_status.go
@@ -107,11 +107,7 @@ func toCRISandboxStatus(meta sandboxstore.Metadata, status sandboxstore.Status,
 		},
 		Linux: &runtime.LinuxPodSandboxStatus{
 			Namespaces: &runtime.Namespace{
-				Options: &runtime.NamespaceOption{
-					Network: nsOpts.GetNetwork(),
-					Pid:     nsOpts.GetPid(),
-					Ipc:     nsOpts.GetIpc(),
-				},
+				Options: nsOpts,
 			},
 		},
 		Labels:         meta.Config.GetLabels(),
