use a const metric for build_info

crosbymichael · crosbymichael · commit 6bec0d39b043 · 2021-09-09T12:20:14.000-04:00
Signed-off-by: Michael Crosby &lt;michael@thepasture.io&gt;
diff --git a/cmd/containerd/command/main.go b/cmd/containerd/command/main.go
@@ -30,7 +30,7 @@ import (
 	"github.com/containerd/containerd/defaults"
 	"github.com/containerd/containerd/errdefs"
 	"github.com/containerd/containerd/log"
-	"github.com/containerd/containerd/metrics"
+	_ "github.com/containerd/containerd/metrics" // import containerd build info
 	"github.com/containerd/containerd/mount"
 	"github.com/containerd/containerd/services/server"
 	srvconfig "github.com/containerd/containerd/services/server/config"
@@ -219,7 +219,6 @@ can be used and modified as necessary as a custom configuration.`
 			serve(ctx, l, server.ServeDebug)
 		}
 		if config.Metrics.Address != "" {
-			metrics.Register()
 			l, err := net.Listen("tcp", config.Metrics.Address)
 			if err != nil {
 				return errors.Wrapf(err, "failed to get listener for metrics endpoint")
diff --git a/metrics/buildinfo.go b/metrics/buildinfo.go
diff --git a/metrics/metrics.go b/metrics/metrics.go
@@ -17,56 +17,13 @@
 package metrics
 
 import (
+	"github.com/containerd/containerd/version"
 	goMetrics "github.com/docker/go-metrics"
-	"github.com/prometheus/client_golang/prometheus"
 )
 
-// Collector provides the ability to collect generic metrics and export
-// them in the prometheus format
-type Collector struct {
-	ns *goMetrics.Namespace
-	m  metric
-}
-
-type metric struct {
-	name   string
-	help   string
-	unit   goMetrics.Unit
-	vt     prometheus.ValueType
-	labels []string
-	// getValues returns the value and labels for the data
-	getValues func() []value
-}
-
-type value struct {
-	v float64
-	l []string
-}
-
-// Describe prometheus metrics
-func (c *Collector) Describe(ch chan<- *prometheus.Desc) {
-	m := c.m
-	ch <- c.ns.NewDesc(m.name, m.help, m.unit, m.labels...)
-}
-
-// Collect prometheus metrics
-func (c *Collector) Collect(ch chan<- prometheus.Metric) {
-	m := c.m
-	for _, v := range m.getValues() {
-		ch <- prometheus.MustNewConstMetric(
-			c.ns.NewDesc(m.name, m.help, m.unit, m.labels...),
-			m.vt,
-			v.v,
-			v.l...,
-		)
-	}
-}
-
-// Register a prometheus namespace for generic metrics
-func Register() {
+func init() {
 	ns := goMetrics.NewNamespace("containerd", "", nil)
-
-	c := newBuildInfoCollector(ns)
-	ns.Add(c)
+	c := ns.NewLabeledCounter("build_info", "containerd build information", "version", "revision")
+	c.WithValues(version.Version, version.Revision).Inc()
 	goMetrics.Register(ns)
 }
