linux: propagate --runtime-root to shim properly

AkihiroSuda · kunalkushwaha · commit 6646106a64cb · 2018-03-08T13:31:00.000+09:00
Signed-off-by: Akihiro Suda &lt;suda.akihiro@lab.ntt.co.jp&gt;
diff --git a/linux/bundle.go b/linux/bundle.go
@@ -69,10 +69,14 @@ type bundle struct {
 type ShimOpt func(*bundle, string, *runctypes.RuncOptions) (shim.Config, client.Opt)
 
 // ShimRemote is a ShimOpt for connecting and starting a remote shim
-func ShimRemote(shimBinary, daemonAddress, cgroup string, debug bool, exitHandler func()) ShimOpt {
+func ShimRemote(c *Config, daemonAddress, cgroup string, exitHandler func()) ShimOpt {
 	return func(b *bundle, ns string, ropts *runctypes.RuncOptions) (shim.Config, client.Opt) {
-		return b.shimConfig(ns, ropts),
-			client.WithStart(shimBinary, b.shimAddress(ns), daemonAddress, cgroup, debug, exitHandler)
+		config := b.shimConfig(ns, ropts)
+		if config.RuntimeRoot == "" {
+			config.RuntimeRoot = c.RuntimeRoot
+		}
+		return config,
+			client.WithStart(c.Shim, b.shimAddress(ns), daemonAddress, cgroup, c.ShimDebug, exitHandler)
 	}
 }
 
diff --git a/linux/runtime.go b/linux/runtime.go
@@ -208,7 +208,7 @@ func (r *Runtime) Create(ctx context.Context, id string, opts runtime.CreateOpts
 				}).Warn("failed to clen up after killed shim")
 			}
 		}
-		shimopt = ShimRemote(r.config.Shim, r.address, cgroup, r.config.ShimDebug, exitHandler)
+		shimopt = ShimRemote(r.config, r.address, cgroup, exitHandler)
 	}
 
 	s, err := bundle.NewShimClient(ctx, namespace, shimopt, ropts)

Original file line number	Diff line number	Diff line change
`@@ -208,7 +208,7 @@ func (r *Runtime) Create(ctx context.Context, id string, opts runtime.CreateOpts`
`208`	`208`	`}).Warn("failed to clen up after killed shim")`
`209`	`209`	`}`
`210`	`210`	`}`
`211`		`- shimopt = ShimRemote(r.config.Shim, r.address, cgroup, r.config.ShimDebug, exitHandler)`
	`211`	`+ shimopt = ShimRemote(r.config, r.address, cgroup, exitHandler)`
`212`	`212`	`}`
`213`	`213`
`214`	`214`	`s, err := bundle.NewShimClient(ctx, namespace, shimopt, ropts)`