Skip to content

Commit 6169433

Browse files
ktockktock
committed
Fix linter issues for golangci-lint 1.54.2
Signed-off-by: Kohei Tokunaga <[email protected]>
1 parent 28fa275 commit 6169433

11 files changed

Lines changed: 11 additions & 6 deletions

File tree

‎content/helpers_test.go‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,7 @@ func TestCopy(t *testing.T) {
143143
}
144144

145145
for _, testcase := range testcases {
146+
testcase := testcase
146147
t.Run(testcase.name, func(t *testing.T) {
147148
err := Copy(context.Background(),
148149
&testcase.writer,

‎metadata/containers_test.go‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -619,6 +619,7 @@ func TestContainersCreateUpdateDelete(t *testing.T) {
619619
},
620620
},
621621
} {
622+
testcase := testcase
622623
t.Run(testcase.name, func(t *testing.T) {
623624
testcase.original.ID = testcase.name
624625
if testcase.input.ID == "" {

‎metadata/images_test.go‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -479,6 +479,7 @@ func TestImagesCreateUpdateDelete(t *testing.T) {
479479
cause: errdefs.ErrNotFound,
480480
},
481481
} {
482+
testcase := testcase
482483
t.Run(testcase.name, func(t *testing.T) {
483484
testcase.original.Name = testcase.name
484485
if testcase.input.Name == "" {

‎metrics/cgroups/v1/oom.go‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,7 @@ func (o *oomCollector) Collect(ch chan<- prometheus.Metric) {
9898
o.mu.Lock()
9999
defer o.mu.Unlock()
100100
for _, t := range o.set {
101+
t := t
101102
c := atomic.LoadInt64(&t.count)
102103
ch <- prometheus.MustNewConstMetric(o.desc, prometheus.CounterValue, float64(c), t.id, t.namespace)
103104
}

‎pkg/cri/sbserver/images/image_status_test.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ import (
2929
)
3030

3131
func TestImageStatus(t *testing.T) {
32-
testID := "sha256:d848ce12891bf78792cda4a23c58984033b0c397a55e93a1556202222ecc5ed4"
32+
testID := "sha256:d848ce12891bf78792cda4a23c58984033b0c397a55e93a1556202222ecc5ed4" // #nosec G101
3333
image := imagestore.Image{
3434
ID: testID,
3535
ChainID: "test-chain-id",

‎pkg/cri/sbserver/images/service_test.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ const (
3535
// Use an image id as test sandbox image to avoid image name resolve.
3636
// TODO(random-liu): Change this to image name after we have complete image
3737
// management unit test framework.
38-
testSandboxImage = "sha256:c75bebcdd211f41b3a460c7bf82970ed6c75acaab9cd4c9a4e125b03ca113798"
38+
testSandboxImage = "sha256:c75bebcdd211f41b3a460c7bf82970ed6c75acaab9cd4c9a4e125b03ca113798" // #nosec G101
3939
)
4040

4141
// newTestCRIService creates a fake criService for test.

‎pkg/cri/sbserver/podsandbox/controller_test.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ const (
3434
// Use an image id as test sandbox image to avoid image name resolve.
3535
// TODO(random-liu): Change this to image name after we have complete image
3636
// management unit test framework.
37-
testSandboxImage = "sha256:c75bebcdd211f41b3a460c7bf82970ed6c75acaab9cd4c9a4e125b03ca113798"
37+
testSandboxImage = "sha256:c75bebcdd211f41b3a460c7bf82970ed6c75acaab9cd4c9a4e125b03ca113798" // #nosec G101
3838
)
3939

4040
var testConfig = criconfig.Config{

‎pkg/cri/sbserver/test_config.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ const (
2424
// Use an image id as test sandbox image to avoid image name resolve.
2525
// TODO(random-liu): Change this to image name after we have complete image
2626
// management unit test framework.
27-
testSandboxImage = "sha256:c75bebcdd211f41b3a460c7bf82970ed6c75acaab9cd4c9a4e125b03ca113798"
27+
testSandboxImage = "sha256:c75bebcdd211f41b3a460c7bf82970ed6c75acaab9cd4c9a4e125b03ca113798" // #nosec G101
2828
)
2929

3030
var testConfig = criconfig.Config{

‎pkg/cri/server/image_status_test.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ import (
2929
)
3030

3131
func TestImageStatus(t *testing.T) {
32-
testID := "sha256:d848ce12891bf78792cda4a23c58984033b0c397a55e93a1556202222ecc5ed4"
32+
testID := "sha256:d848ce12891bf78792cda4a23c58984033b0c397a55e93a1556202222ecc5ed4" // #nosec G101
3333
image := imagestore.Image{
3434
ID: testID,
3535
ChainID: "test-chain-id",

‎pkg/cri/server/test_config.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ const (
2424
// Use an image id as test sandbox image to avoid image name resolve.
2525
// TODO(random-liu): Change this to image name after we have complete image
2626
// management unit test framework.
27-
testSandboxImage = "sha256:c75bebcdd211f41b3a460c7bf82970ed6c75acaab9cd4c9a4e125b03ca113798"
27+
testSandboxImage = "sha256:c75bebcdd211f41b3a460c7bf82970ed6c75acaab9cd4c9a4e125b03ca113798" // #nosec G101
2828
testImageFSPath = "/test/image/fs/path"
2929
)
3030

0 commit comments

Comments
 (0)