Skip to content

Commit 5ea9363

Browse files
committed
Perfect documentation
Signed-off-by: yuxiaobo <[email protected]>
1 parent aba2013 commit 5ea9363

7 files changed

Lines changed: 7 additions & 7 deletions

File tree

metadata/db.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ type DB struct {
7676
// sweep phases without preventing read transactions.
7777
wlock sync.RWMutex
7878

79-
// dirty flag indicates that refences have been removed which require
79+
// dirty flag indicates that references have been removed which require
8080
// a garbage collection to ensure the database is clean. This tracks
8181
// the number of dirty operations. This should be updated and read
8282
// atomically if outside of wlock.Lock.

namespaces/context.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ func Namespace(ctx context.Context) (string, bool) {
6464
return namespace, ok
6565
}
6666

67-
// NamespaceRequired returns the valid namepace from the context or an error.
67+
// NamespaceRequired returns the valid namespace from the context or an error.
6868
func NamespaceRequired(ctx context.Context) (string, error) {
6969
namespace, ok := Namespace(ctx)
7070
if !ok || namespace == "" {

reports/2017-01-13.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ We finished porting over the shim from the existing containerd implementation th
3737

3838
* https://github.com/containerd/containerd/pull/417
3939

40-
## Whats Next?
40+
## What's Next?
4141

4242
Next week we will be working towards a full PoC with the runtime, storage, and fetching of images. Getting the core functionality up and running quickly is important to us to ensure that integration between the different subsystems in the core flow well together. We want to make sure the responsibilities of pulling an image from a remote source do not spill into the storage layer and vice-versa.
4343

reports/2017-04-28.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ Justin has begun work on porting over containerd to Darwin and BSD. `ctr` compi
2626

2727
## Task List for week of May 1
2828

29-
So, now that we are all back from Dockercon and not rested at all, whats on the agenda for next week?
29+
So, now that we are all back from Dockercon and not rested at all, what's on the agenda for next week?
3030

3131
* Docker Integration Pass
3232
- Replace the current v0.2.x branch of containerd in Docker for execution with the 1.0 execution service

reports/2017-05-19.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
Moving more functionality into containerd means more requirements from users. One thing that we have ran into was the disconnect of what our Container model is and what users expect, `docker create;docker start;docker rm` vs a container that is destroyed when it exits.
66

7-
To users, containers are more of a metadata object that resources(rw, configuration) and information(state, last exit status) are attached to. We have been reworking what we call a "container" today to be called a "task" and a Container metadata object. The task only has runtime state: a pid, namepsaces, cgroups, etc. A container has an id, root filesystem, configuration, and other metadata from a user.
7+
To users, containers are more of a metadata object that resources(rw, configuration) and information(state, last exit status) are attached to. We have been reworking what we call a "container" today to be called a "task" and a Container metadata object. The task only has runtime state: a pid, namespaces, cgroups, etc. A container has an id, root filesystem, configuration, and other metadata from a user.
88

99
Managing static state and runtime state in the same object is very tricky so we choose to keep execution and metadata separate. We are hoping to not cause more confusion with this additional task object. You can see a mockup of a client interacting with a container and how the task is handled below:
1010

reports/2017-05-26.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ We also designed the client to allow mocking of calls so that our tests can be m
124124
You can view the PR [here](https://github.com/containerd/containerd/pull/910).
125125

126126

127-
## Whats Next?
127+
## What's Next?
128128

129129
We still need to finish Events. This is one of the last major features that we need before we consider containerd feature complete. The namespace work is in progress with the initial service spec'd.
130130

reports/2017-06-09.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ We added updates to the client to support attach, checkpoint and restore, exec o
2828
[checkpoint](https://github.com/containerd/containerd/pull/958)
2929
[attach](https://github.com/containerd/containerd/pull/976)
3030

31-
# Whats Next?
31+
# What's Next?
3232

3333
We only have a few features left to implement, such as [events](https://github.com/containerd/containerd/pull/956), for our 1.0 release. The rest of the month we are working on usability, bug fixes, and stability.
3434

0 commit comments

Comments
 (0)