converter: use OpenWriter helper function

ktock · ktock · commit 5c02688b59e3 · 2021-04-15T19:05:10.000+09:00
When several goroutines call uncompress converter in parallel, the ref name
conflicts each other. This leads to Writer method failing with Unavaliable error
without retry.
For solving this issue, OpenWriter helper should be used. This allows them to
retry in such situations.

Signed-off-by: Kohei Tokunaga &lt;ktokunaga.mail@gmail.com&gt;
diff --git a/images/converter/uncompress/uncompress.go b/images/converter/uncompress/uncompress.go
@@ -55,7 +55,7 @@ func LayerConvertFunc(ctx context.Context, cs content.Store, desc ocispec.Descri
 	}
 	defer newR.Close()
 	ref := fmt.Sprintf("convert-uncompress-from-%s", desc.Digest)
-	w, err := cs.Writer(ctx, content.WithRef(ref))
+	w, err := content.OpenWriter(ctx, cs, content.WithRef(ref))
 	if err != nil {
 		return nil, err
 	}

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ func LayerConvertFunc(ctx context.Context, cs content.Store, desc ocispec.Descri`
`55`	`55`	`}`
`56`	`56`	`defer newR.Close()`
`57`	`57`	`ref := fmt.Sprintf("convert-uncompress-from-%s", desc.Digest)`
`58`		`- w, err := cs.Writer(ctx, content.WithRef(ref))`
	`58`	`+ w, err := content.OpenWriter(ctx, cs, content.WithRef(ref))`
`59`	`59`	`if err != nil {`
`60`	`60`	`return nil, err`
`61`	`61`	`}`