Remove hardcoded /tmp in tempfile paths

TBBle · TBBle · commit 5b78a9a8f139 · 2022-03-06T17:32:25.000+11:00
There's no specific need mentioned at the points it was added, and it
makes the Windows-hosted test run setup slightly weird.

Signed-off-by: Paul "TBBle" Hampson &lt;Paul.Hampson@Pobox.com&gt;
diff --git a/.github/workflows/windows-periodic.yml b/.github/workflows/windows-periodic.yml
@@ -183,7 +183,6 @@ jobs:
            ssh -i $HOME/.ssh/id_rsa ${{ env.SSH_OPTS }} azureuser@${{ env.VM_PUB_IP }} "sh.exe -s" <<EOF
              cd c:/containerd
              ./script/setup/install-cni-windows
-             mkdir /c/tmp
              export TEST_IMAGE_LIST=c:/repolist.toml
              make cri-integration | tee c:/Logs/cri-integration.log
            EOF
diff --git a/integration/addition_gids_test.go b/integration/addition_gids_test.go
@@ -31,7 +31,7 @@ import (
 )
 
 func TestAdditionalGids(t *testing.T) {
-	testPodLogDir, err := os.MkdirTemp("/tmp", "additional-gids")
+	testPodLogDir, err := os.MkdirTemp("", "additional-gids")
 	require.NoError(t, err)
 	defer os.RemoveAll(testPodLogDir)
 
diff --git a/integration/container_log_test.go b/integration/container_log_test.go
@@ -30,7 +30,7 @@ import (
 )
 
 func TestContainerLogWithoutTailingNewLine(t *testing.T) {
-	testPodLogDir, err := os.MkdirTemp("/tmp", "container-log-without-tailing-newline")
+	testPodLogDir, err := os.MkdirTemp("", "container-log-without-tailing-newline")
 	require.NoError(t, err)
 	defer os.RemoveAll(testPodLogDir)
 
@@ -80,7 +80,7 @@ func TestContainerLogWithoutTailingNewLine(t *testing.T) {
 }
 
 func TestLongContainerLog(t *testing.T) {
-	testPodLogDir, err := os.MkdirTemp("/tmp", "long-container-log")
+	testPodLogDir, err := os.MkdirTemp("", "long-container-log")
 	require.NoError(t, err)
 	defer os.RemoveAll(testPodLogDir)
 
diff --git a/integration/pod_dualstack_test.go b/integration/pod_dualstack_test.go
@@ -31,7 +31,7 @@ import (
 )
 
 func TestPodDualStack(t *testing.T) {
-	testPodLogDir, err := os.MkdirTemp("/tmp", "dualstack")
+	testPodLogDir, err := os.MkdirTemp("", "dualstack")
 	require.NoError(t, err)
 	defer os.RemoveAll(testPodLogDir)
 
diff --git a/integration/pod_hostname_test.go b/integration/pod_hostname_test.go
@@ -64,7 +64,7 @@ func TestPodHostname(t *testing.T) {
 			if test.needsHostNetwork && goruntime.GOOS == "windows" {
 				t.Skip("Skipped on Windows.")
 			}
-			testPodLogDir, err := os.MkdirTemp("/tmp", "hostname")
+			testPodLogDir, err := os.MkdirTemp("", "hostname")
 			require.NoError(t, err)
 			defer os.RemoveAll(testPodLogDir)
 

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ import (`
`31`	`31`	`)`
`32`	`32`
`33`	`33`	`func TestAdditionalGids(t *testing.T) {`
`34`		`- testPodLogDir, err := os.MkdirTemp("/tmp", "additional-gids")`
	`34`	`+ testPodLogDir, err := os.MkdirTemp("", "additional-gids")`
`35`	`35`	`require.NoError(t, err)`
`36`	`36`	`defer os.RemoveAll(testPodLogDir)`
`37`	`37`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ import (`
`30`	`30`	`)`
`31`	`31`
`32`	`32`	`func TestContainerLogWithoutTailingNewLine(t *testing.T) {`
`33`		`- testPodLogDir, err := os.MkdirTemp("/tmp", "container-log-without-tailing-newline")`
	`33`	`+ testPodLogDir, err := os.MkdirTemp("", "container-log-without-tailing-newline")`
`34`	`34`	`require.NoError(t, err)`
`35`	`35`	`defer os.RemoveAll(testPodLogDir)`
`36`	`36`
`@@ -80,7 +80,7 @@ func TestContainerLogWithoutTailingNewLine(t *testing.T) {`
`80`	`80`	`}`
`81`	`81`
`82`	`82`	`func TestLongContainerLog(t *testing.T) {`
`83`		`- testPodLogDir, err := os.MkdirTemp("/tmp", "long-container-log")`
	`83`	`+ testPodLogDir, err := os.MkdirTemp("", "long-container-log")`
`84`	`84`	`require.NoError(t, err)`
`85`	`85`	`defer os.RemoveAll(testPodLogDir)`
`86`	`86`
Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ func TestPodHostname(t *testing.T) {`
`64`	`64`	`if test.needsHostNetwork && goruntime.GOOS == "windows" {`
`65`	`65`	`t.Skip("Skipped on Windows.")`
`66`	`66`	`}`
`67`		`- testPodLogDir, err := os.MkdirTemp("/tmp", "hostname")`
	`67`	`+ testPodLogDir, err := os.MkdirTemp("", "hostname")`
`68`	`68`	`require.NoError(t, err)`
`69`	`69`	`defer os.RemoveAll(testPodLogDir)`
`70`	`70`