remove exec sync debug contents from logs

crosbymichael · crosbymichael · commit 591d7e2fb1af · 2021-01-26T14:57:54.000-05:00
This was dumping untrusted output to the debug logs from user containers.
We should not dump this type of information to reduce log sizes and any
information leaks from user containers.

Signed-off-by: Michael Crosby &lt;michael@thepasture.io&gt;
diff --git a/pkg/cri/server/instrumented_service.go b/pkg/cri/server/instrumented_service.go
@@ -253,8 +253,6 @@ func (in *instrumentedService) ExecSync(ctx context.Context, r *runtime.ExecSync
 			log.G(ctx).WithError(err).Errorf("ExecSync for %q failed", r.GetContainerId())
 		} else {
 			log.G(ctx).Debugf("ExecSync for %q returns with exit code %d", r.GetContainerId(), res.GetExitCode())
-			log.G(ctx).Debugf("ExecSync for %q outputs - stdout: %q, stderr: %q", r.GetContainerId(),
-				res.GetStdout(), res.GetStderr())
 		}
 	}()
 	res, err = in.c.ExecSync(ctrdutil.WithNamespace(ctx), r)

Original file line number	Diff line number	Diff line change
`@@ -253,8 +253,6 @@ func (in instrumentedService) ExecSync(ctx context.Context, r runtime.ExecSync`
`253`	`253`	`log.G(ctx).WithError(err).Errorf("ExecSync for %q failed", r.GetContainerId())`
`254`	`254`	`} else {`
`255`	`255`	`log.G(ctx).Debugf("ExecSync for %q returns with exit code %d", r.GetContainerId(), res.GetExitCode())`
`256`		`- log.G(ctx).Debugf("ExecSync for %q outputs - stdout: %q, stderr: %q", r.GetContainerId(),`
`257`		`- res.GetStdout(), res.GetStderr())`
`258`	`256`	`}`
`259`	`257`	`}()`
`260`	`258`	`res, err = in.c.ExecSync(ctrdutil.WithNamespace(ctx), r)`