Make checkContainerTimestamps less strict on Windows

Kazuyoshi Kato · thaJeztah · commit 568ce91ca590 · 2023-07-14T13:51:10.000+02:00
This assertion is flaky on Windows. Because of Go, Windows' time.Now resolution is lower than Linux. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com> (cherry picked from commit 407703f) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
diff --git a/metadata/containers_test.go b/metadata/containers_test.go
@@ -22,6 +22,7 @@ import (
 	"fmt"
 	"path/filepath"
 	"reflect"
+	"runtime"
 	"testing"
 	"time"
 
@@ -693,7 +694,12 @@ func checkContainerTimestamps(t *testing.T, c *containers.Container, now time.Ti
 	} else {
 		// ensure that updatedat is always after createdat
 		if !c.UpdatedAt.After(c.CreatedAt) {
-			t.Fatalf("timestamp for updatedat not after createdat: %v <= %v", c.UpdatedAt, c.CreatedAt)
+			if runtime.GOOS == "windows" && c.UpdatedAt == c.CreatedAt {
+				// Windows' time.Now resolution is lower than Linux, due to Go.
+				// https://github.com/golang/go/issues/31160
+			} else {
+				t.Fatalf("timestamp for updatedat not after createdat: %v <= %v", c.UpdatedAt, c.CreatedAt)
+			}
 		}
 	}
 
