Skip to content

Commit 55a9bbc

Browse files
committed
Prevent runc inheriting BUILDTAGS from containerd
Both runc and containerd use BUILDTAGS to customize go build-tags. When building containerd with custom build-tags, runc inherited those, causing the default to be overwritten, e.g.; make BUILDTAGS=no_btrfs cri-cni-release (in script/setup/install-runc) HEAD is now at 12644e61 VERSION: release 1.0.0~rc93 make[1]: Entering directory '/tmp/tmp.ZJzc2KtI0A/runc' go build -trimpath "-mod=vendor" "-buildmode=pie" -tags "no_btrfs" -ldflags "-X main.gitCommit="12644e614e25b05da6fd08a38ffa0cfe1903fdec" -X main.version=1.0.0-rc93 " -o runc . ^^^^^^^^^^^^^^^^ This patch brings back the BUILDTAGS make-var in the runc-install script, which fixates the buildtags to our defaults. Signed-off-by: Sebastiaan van Stijn <[email protected]>
1 parent 9d5c116 commit 55a9bbc

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

script/setup/install-runc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ function install_runc() {
3030
git clone https://github.com/opencontainers/runc.git "${TMPROOT}"/runc
3131
pushd "${TMPROOT}"/runc
3232
git checkout "${RUNC_VERSION}"
33-
make
33+
make BUILDTAGS='seccomp' runc
3434
make install
3535
popd
3636
rm -fR "${TMPROOT}"

0 commit comments

Comments
 (0)