Fix bug in setting request body

dmcgowan · dmcgowan · commit 518be1cb0705 · 2019-07-18T11:21:51.000-07:00
Go documentation says
`Use of GetBody still requires setting Body`.
This change ensures the body is always set in
addition to GetBody. This fixes a bug where
sometimes the body is nil.

Signed-off-by: Derek McGowan &lt;derek@mcgstyle.net&gt;
diff --git a/remotes/docker/pusher.go b/remotes/docker/pusher.go
@@ -230,9 +230,16 @@ func (p dockerPusher) Push(ctx context.Context, desc ocispec.Descriptor) (conten
 
 	pr, pw := io.Pipe()
 	respC := make(chan *http.Response, 1)
+	body := ioutil.NopCloser(pr)
 
 	req.body = func() (io.ReadCloser, error) {
-		return ioutil.NopCloser(pr), nil
+		if body == nil {
+			return nil, errors.New("cannot reuse body, request must be retried")
+		}
+		// Only use the body once since pipe cannot be seeked
+		ob := body
+		body = nil
+		return ob, nil
 	}
 	req.size = desc.Size
 
diff --git a/remotes/docker/resolver.go b/remotes/docker/resolver.go
@@ -495,6 +495,11 @@ func (r *request) do(ctx context.Context) (*http.Response, error) {
 	}
 	req.Header = r.header
 	if r.body != nil {
+		body, err := r.body()
+		if err != nil {
+			return nil, err
+		}
+		req.Body = body
 		req.GetBody = r.body
 		if r.size > 0 {
 			req.ContentLength = r.size
