Skip to content

Commit 50740a1

Browse files
everpeaceeverpeace
committed
use strings.Cut instead of strings.Split for parsing imageConfig.User
Signed-off-by: Shingo Omura <[email protected]>
1 parent 727b254 commit 50740a1

2 files changed

Lines changed: 2 additions & 4 deletions

File tree

‎pkg/cri/sbserver/container_create_linux.go‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,8 +136,7 @@ func (c *criService) containerSpecOpts(config *runtime.ContainerConfig, imageCon
136136
} else if securityContext.GetRunAsUser() != nil {
137137
userstr = strconv.FormatInt(securityContext.GetRunAsUser().GetValue(), 10)
138138
} else if imageConfig.User != "" {
139-
parts := strings.Split(imageConfig.User, ":")
140-
userstr = parts[0]
139+
userstr, _, _ = strings.Cut(imageConfig.User, ":")
141140
}
142141
specOpts = append(specOpts, customopts.WithAdditionalGIDs(userstr),
143142
customopts.WithSupplementalGroups(securityContext.GetSupplementalGroups()))

‎pkg/cri/server/container_create_linux.go‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -372,8 +372,7 @@ func (c *criService) containerSpecOpts(config *runtime.ContainerConfig, imageCon
372372
} else if securityContext.GetRunAsUser() != nil {
373373
userstr = strconv.FormatInt(securityContext.GetRunAsUser().GetValue(), 10)
374374
} else if imageConfig.User != "" {
375-
parts := strings.Split(imageConfig.User, ":")
376-
userstr = parts[0]
375+
userstr, _, _ = strings.Cut(imageConfig.User, ":")
377376
}
378377
specOpts = append(specOpts, customopts.WithAdditionalGIDs(userstr),
379378
customopts.WithSupplementalGroups(securityContext.GetSupplementalGroups()))

0 commit comments

Comments
 (0)