Skip to content

Commit 4674ad7

Browse files
committed
Ignore some tests on darwin
Signed-off-by: Maksym Pavlenko <[email protected]>
1 parent 55450e7 commit 4674ad7

3 files changed

Lines changed: 15 additions & 1 deletion

File tree

archive/tar_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// +build !windows
1+
// +build !windows,!darwin
22

33
/*
44
Copyright The containerd Authors.

pkg/cri/server/container_create_test.go

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ package server
1919
import (
2020
"context"
2121
"path/filepath"
22+
goruntime "runtime"
2223
"testing"
2324

2425
"github.com/containerd/containerd/oci"
@@ -68,6 +69,10 @@ func TestGeneralContainerSpec(t *testing.T) {
6869
}
6970

7071
func TestPodAnnotationPassthroughContainerSpec(t *testing.T) {
72+
if goruntime.GOOS == "darwin" {
73+
t.Skip("not implemented on Darwin")
74+
}
75+
7176
testID := "test-id"
7277
testSandboxID := "sandbox-id"
7378
testContainerName := "container-name"
@@ -272,6 +277,10 @@ func TestVolumeMounts(t *testing.T) {
272277
}
273278

274279
func TestContainerAnnotationPassthroughContainerSpec(t *testing.T) {
280+
if goruntime.GOOS == "darwin" {
281+
t.Skip("not implemented on Darwin")
282+
}
283+
275284
testID := "test-id"
276285
testSandboxID := "sandbox-id"
277286
testContainerName := "container-name"

pkg/cri/server/sandbox_run_test.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ package server
1818

1919
import (
2020
"net"
21+
goruntime "runtime"
2122
"testing"
2223

2324
cni "github.com/containerd/go-cni"
@@ -33,6 +34,10 @@ import (
3334
)
3435

3536
func TestSandboxContainerSpec(t *testing.T) {
37+
if goruntime.GOOS == "darwin" {
38+
t.Skip("not implemented on Darwin")
39+
}
40+
3641
testID := "test-id"
3742
nsPath := "test-cni"
3843
for desc, test := range map[string]struct {

0 commit comments

Comments
 (0)