Fail integration test early when a plugin load fails

dmcgowan · dmcgowan · commit 40012b6445f6 · 2024-06-12T11:09:41.000-07:00
Avoid running tests when a plugin fails to load and return the init error from the plugin. This prevents the test failing later with an unhelpful error and attempting to find the actual error in the daemon logs. Signed-off-by: Derek McGowan <derek@mcg.dev> (cherry picked from commit b1a23c4) Signed-off-by: Derek McGowan <derek@mcg.dev>
diff --git a/integration/client/daemon.go b/integration/client/daemon.go
@@ -23,11 +23,13 @@ import (
 	"io"
 	"os/exec"
 	"runtime"
+	"strings"
 	"sync"
 	"syscall"
 	"time"
 
 	. "github.com/containerd/containerd"
+	"github.com/containerd/containerd/plugin"
 )
 
 type daemon struct {
@@ -79,6 +81,21 @@ func (d *daemon) waitForStart(ctx context.Context) (*Client, error) {
 				}
 				continue
 			}
+			resp, perr := client.IntrospectionService().Plugins(ctx, nil)
+			if perr != nil {
+				return nil, fmt.Errorf("failed to get plugin list: %w", perr)
+			}
+			var loadErr error
+			for _, p := range resp.Plugins {
+				if p.InitErr != nil && !strings.Contains(p.InitErr.Message, plugin.ErrSkipPlugin.Error()) {
+					pluginErr := fmt.Errorf("failed to load %s.%s: %s", p.Type, p.ID, p.InitErr.Message)
+					loadErr = errors.Join(loadErr, pluginErr)
+				}
+			}
+			if loadErr != nil {
+				return nil, loadErr
+			}
+
 			return client, err
 		case <-ctx.Done():
 			return nil, fmt.Errorf("context deadline exceeded: %w", err)
