metadata/gc: remove the noop-loop for snapshot reference

fuweid · fuweid · commit 3e6d7f678dd2 · 2019-01-30T10:01:29.000+08:00
The noop-loop does nothing. The containerd doesn't have any snapshotter buckets at the beginning. If user uses specific dir as rootfs to create container, and sets `snapshotter` key to the container, like `overlayfs` by mistake, the gc scheduler will try to scan the snapshotter and panic. In order to avoid this case, remove the noop-loop here. Signed-off-by: Wei Fu <fuweid89@gmail.com> (cherry picked from commit 34672d4) Signed-off-by: Wei Fu <fuweid89@gmail.com>
diff --git a/metadata/gc.go b/metadata/gc.go
@@ -227,10 +227,6 @@ func references(ctx context.Context, tx *bolt.Tx, node gc.Node, fn func(gc.Node)
 
 		bkt := getBucket(tx, bucketKeyVersion, []byte(node.Namespace), bucketKeyObjectSnapshots, []byte(ss), []byte(name))
 		if bkt == nil {
-			getBucket(tx, bucketKeyVersion, []byte(node.Namespace), bucketKeyObjectSnapshots).ForEach(func(k, v []byte) error {
-				return nil
-			})
-
 			// Node may be created from dead edge
 			return nil
 		}
