Skip to content

Commit 3923c02

Browse files
Merge pull request #3254 from jcordasc/cherrypick-annotation-fix-1.2
[release/1.2 backport] Add missing annotations map to Descriptor for gRPC transfer
2 parents 9196892 + 9ad688a commit 3923c02

15 files changed

Lines changed: 437 additions & 62 deletions

File tree

api/next.pb.txt

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1764,6 +1764,34 @@ file {
17641764
type: TYPE_INT64
17651765
json_name: "size"
17661766
}
1767+
field {
1768+
name: "annotations"
1769+
number: 5
1770+
label: LABEL_REPEATED
1771+
type: TYPE_MESSAGE
1772+
type_name: ".containerd.types.Descriptor.AnnotationsEntry"
1773+
json_name: "annotations"
1774+
}
1775+
nested_type {
1776+
name: "AnnotationsEntry"
1777+
field {
1778+
name: "key"
1779+
number: 1
1780+
label: LABEL_OPTIONAL
1781+
type: TYPE_STRING
1782+
json_name: "key"
1783+
}
1784+
field {
1785+
name: "value"
1786+
number: 2
1787+
label: LABEL_OPTIONAL
1788+
type: TYPE_STRING
1789+
json_name: "value"
1790+
}
1791+
options {
1792+
map_entry: true
1793+
}
1794+
}
17671795
}
17681796
options {
17691797
go_package: "github.com/containerd/containerd/api/types;types"

api/types/descriptor.pb.go

Lines changed: 175 additions & 14 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

api/types/descriptor.proto

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,4 +15,5 @@ message Descriptor {
1515
string media_type = 1;
1616
string digest = 2 [(gogoproto.customtype) = "github.com/opencontainers/go-digest.Digest", (gogoproto.nullable) = false];
1717
int64 size = 3;
18+
map<string, string> annotations = 5;
1819
}

diff.go

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -80,17 +80,19 @@ func (r *diffRemote) Compare(ctx context.Context, a, b []mount.Mount, opts ...di
8080

8181
func toDescriptor(d *types.Descriptor) ocispec.Descriptor {
8282
return ocispec.Descriptor{
83-
MediaType: d.MediaType,
84-
Digest: d.Digest,
85-
Size: d.Size_,
83+
MediaType: d.MediaType,
84+
Digest: d.Digest,
85+
Size: d.Size_,
86+
Annotations: d.Annotations,
8687
}
8788
}
8889

8990
func fromDescriptor(d ocispec.Descriptor) *types.Descriptor {
9091
return &types.Descriptor{
91-
MediaType: d.MediaType,
92-
Digest: d.Digest,
93-
Size_: d.Size,
92+
MediaType: d.MediaType,
93+
Digest: d.Digest,
94+
Size_: d.Size,
95+
Annotations: d.Annotations,
9496
}
9597
}
9698

image_store.go

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -137,16 +137,18 @@ func imagesFromProto(imagespb []imagesapi.Image) []images.Image {
137137

138138
func descFromProto(desc *types.Descriptor) ocispec.Descriptor {
139139
return ocispec.Descriptor{
140-
MediaType: desc.MediaType,
141-
Size: desc.Size_,
142-
Digest: desc.Digest,
140+
MediaType: desc.MediaType,
141+
Size: desc.Size_,
142+
Digest: desc.Digest,
143+
Annotations: desc.Annotations,
143144
}
144145
}
145146

146147
func descToProto(desc *ocispec.Descriptor) types.Descriptor {
147148
return types.Descriptor{
148-
MediaType: desc.MediaType,
149-
Size_: desc.Size,
150-
Digest: desc.Digest,
149+
MediaType: desc.MediaType,
150+
Size_: desc.Size,
151+
Digest: desc.Digest,
152+
Annotations: desc.Annotations,
151153
}
152154
}

0 commit comments

Comments
 (0)