pod: CreatedAt time will be 269 years ago while creating cri network failed.

zzzzzzzzzy9 · AkihiroSuda · commit 293f5151d44c · 2024-04-23T23:37:55.000+09:00
We should set sandbox CreatedAt first time when we create sandbox struct, and then set sandbox CreatedAt second time after container started. Before this commit, we just set sandbox CreatedAt after container started, but if network create failed, the sandbox time is the default time, which is 269 years ago, so we need to set sandbox CreatedAt at first, even if an error occurred before start container. Signed-off-by: zzzzzzzzzy9 <zhang.yu58@zte.com.cn> (cherry picked from commit b16d467) There was no merge conflict, but the commit was amended to cover sbserver. Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
diff --git a/pkg/cri/sbserver/sandbox_run.go b/pkg/cri/sbserver/sandbox_run.go
@@ -120,7 +120,8 @@ func (c *criService) RunPodSandbox(ctx context.Context, r *runtime.RunPodSandbox
 			RuntimeHandler: r.GetRuntimeHandler(),
 		},
 		sandboxstore.Status{
-			State: sandboxstore.StateUnknown,
+			State:     sandboxstore.StateUnknown,
+			CreatedAt: time.Now().UTC(),
 		},
 	)
 
diff --git a/pkg/cri/server/sandbox_run.go b/pkg/cri/server/sandbox_run.go
@@ -96,7 +96,8 @@ func (c *criService) RunPodSandbox(ctx context.Context, r *runtime.RunPodSandbox
 			RuntimeHandler: r.GetRuntimeHandler(),
 		},
 		sandboxstore.Status{
-			State: sandboxstore.StateUnknown,
+			State:     sandboxstore.StateUnknown,
+			CreatedAt: time.Now().UTC(),
 		},
 	)
 

Original file line number	Diff line number	Diff line change
`@@ -120,7 +120,8 @@ func (c criService) RunPodSandbox(ctx context.Context, r runtime.RunPodSandbox`
`120`	`120`	`RuntimeHandler: r.GetRuntimeHandler(),`
`121`	`121`	`},`
`122`	`122`	`sandboxstore.Status{`
`123`		`- State: sandboxstore.StateUnknown,`
	`123`	`+ State: sandboxstore.StateUnknown,`
	`124`	`+ CreatedAt: time.Now().UTC(),`
`124`	`125`	`},`
`125`	`126`	`)`
`126`	`127`
Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,8 @@ func (c criService) RunPodSandbox(ctx context.Context, r runtime.RunPodSandbox`
`96`	`96`	`RuntimeHandler: r.GetRuntimeHandler(),`
`97`	`97`	`},`
`98`	`98`	`sandboxstore.Status{`
`99`		`- State: sandboxstore.StateUnknown,`
	`99`	`+ State: sandboxstore.StateUnknown,`
	`100`	`+ CreatedAt: time.Now().UTC(),`
`100`	`101`	`},`
`101`	`102`	`)`
`102`	`103`