Skip to content

Commit 246a560

Browse files
committed
script: use github.com/kubernetes-sigs/cri-tools directly
When we call `go get -d -v github.com/kubernetes-incubator/cri-tools/...` which repos has been moved to `github.com/kubernetes-sigs/cri-tools`, `go get` will create package `github.com/kubernetes-sigs/cri-tools`. ``` go get -d -v github.com/kubernetes-incubator/cri-tools/... github.com/kubernetes-incubator/cri-tools (download) github.com/kubernetes-sigs/cri-tools (download) ``` According to old version of `github.com/kubernetes-incubator/cri-tools` Makefile, if there is no `github.com/kubernetes-sigs/cri-tools` package, it will create softlink self to `github.com/kubernetes-sigs/cri-tools`. But `go get` will create `github.com/kubernetes-sigs/cri-tools` and there is no softlink. Therefore, the critools are always latest one, not specific version. So, use `github.com/kubernetes-sigs/cri-tools` will be better and save traffic from `go get`. Signed-off-by: Wei Fu <[email protected]>
1 parent 27f2506 commit 246a560

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

script/setup/install-critools

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ set -eu -o pipefail
2222

2323
go get -u github.com/onsi/ginkgo/ginkgo
2424
CRITEST_COMMIT=v1.16.1
25-
go get -d github.com/kubernetes-incubator/cri-tools/...
26-
cd "$GOPATH"/src/github.com/kubernetes-incubator/cri-tools
25+
go get -d github.com/kubernetes-sigs/cri-tools/...
26+
cd "$GOPATH"/src/github.com/kubernetes-sigs/cri-tools
2727
git checkout $CRITEST_COMMIT
2828
make
2929
make install

0 commit comments

Comments
 (0)