Merge pull request #2710 from fuweid/enhance_support_duration_for_cpu_profile_collection

estesp · web-flow · commit 1a5f9a3434ac · 2018-10-11T11:00:25.000-04:00
enhance: support specific duration for profile collection
diff --git a/cmd/ctr/commands/pprof/pprof.go b/cmd/ctr/commands/pprof/pprof.go
@@ -89,10 +89,18 @@ var pprofHeapCommand = cli.Command{
 var pprofProfileCommand = cli.Command{
 	Name:  "profile",
 	Usage: "CPU profile",
+	Flags: []cli.Flag{
+		cli.DurationFlag{
+			Name:  "seconds,s",
+			Usage: "duration for collection (seconds)",
+			Value: 30 * time.Second,
+		},
+	},
 	Action: func(context *cli.Context) error {
 		client := getPProfClient(context)
 
-		output, err := httpGetRequest(client, "/debug/pprof/profile")
+		seconds := context.Duration("seconds").Seconds()
+		output, err := httpGetRequest(client, fmt.Sprintf("/debug/pprof/profile?seconds=%v", seconds))
 		if err != nil {
 			return err
 		}
