Set grpc code for unimplemented cri-api methods

ruiwen-zhao · ruiwen-zhao · commit 0f7e258eebbf · 2022-09-22T20:19:46.000Z
Signed-off-by: ruiwen-zhao &lt;ruiwen@google.com&gt;
diff --git a/pkg/cri/server/container_checkpoint.go b/pkg/cri/server/container_checkpoint.go
@@ -18,11 +18,12 @@ package server
 
 import (
 	"context"
-	"errors"
 
+	"google.golang.org/grpc/codes"
+	"google.golang.org/grpc/status"
 	runtime "k8s.io/cri-api/pkg/apis/runtime/v1"
 )
 
 func (c *criService) CheckpointContainer(ctx context.Context, r *runtime.CheckpointContainerRequest) (res *runtime.CheckpointContainerResponse, err error) {
-	return nil, errors.New("not implemented")
+	return nil, status.Errorf(codes.Unimplemented, "method CheckpointContainer not implemented")
 }
diff --git a/pkg/cri/server/container_events.go b/pkg/cri/server/container_events.go
@@ -17,11 +17,11 @@
 package server
 
 import (
-	"errors"
-
+	"google.golang.org/grpc/codes"
+	"google.golang.org/grpc/status"
 	runtime "k8s.io/cri-api/pkg/apis/runtime/v1"
 )
 
 func (c *criService) GetContainerEvents(r *runtime.GetEventsRequest, s runtime.RuntimeService_GetContainerEventsServer) error {
-	return errors.New("not implemented")
+	return status.Errorf(codes.Unimplemented, "method GetContainerEvents not implemented")
 }

Original file line number	Diff line number	Diff line change
`@@ -18,11 +18,12 @@ package server`
`18`	`18`
`19`	`19`	`import (`
`20`	`20`	`"context"`
`21`		`- "errors"`
`22`	`21`
	`22`	`+ "google.golang.org/grpc/codes"`
	`23`	`+ "google.golang.org/grpc/status"`
`23`	`24`	`runtime "k8s.io/cri-api/pkg/apis/runtime/v1"`
`24`	`25`	`)`
`25`	`26`
`26`	`27`	`func (c criService) CheckpointContainer(ctx context.Context, r runtime.CheckpointContainerRequest) (res *runtime.CheckpointContainerResponse, err error) {`
`27`		`- return nil, errors.New("not implemented")`
	`28`	`+ return nil, status.Errorf(codes.Unimplemented, "method CheckpointContainer not implemented")`
`28`	`29`	`}`
Original file line number	Diff line number	Diff line change
`@@ -17,11 +17,11 @@`
`17`	`17`	`package server`
`18`	`18`
`19`	`19`	`import (`
`20`		`- "errors"`
`21`		`-`
	`20`	`+ "google.golang.org/grpc/codes"`
	`21`	`+ "google.golang.org/grpc/status"`
`22`	`22`	`runtime "k8s.io/cri-api/pkg/apis/runtime/v1"`
`23`	`23`	`)`
`24`	`24`
`25`	`25`	`func (c criService) GetContainerEvents(r runtime.GetEventsRequest, s runtime.RuntimeService_GetContainerEventsServer) error {`
`26`		`- return errors.New("not implemented")`
	`26`	`+ return status.Errorf(codes.Unimplemented, "method GetContainerEvents not implemented")`
`27`	`27`	`}`